Last modified: 2014-04-28 19:57:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65573, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 63573 - http->https rewrite (=prefershttps) also rewrites http search urls for Special:Linksearch
http->https rewrite (=prefershttps) also rewrites http search urls for Specia...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
1.23.0
All All
: Low normal (vote)
: ---
Assigned To: Nobody - You can work on this!
http://de.wikipedia.org/wiki/Spezial:...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-04-05 14:35 UTC by merl
Modified: 2014-04-28 19:57 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description merl 2014-04-05 14:35:01 UTC
With preferhttps option enabled by logged in users

http://de.wikipedia.org/wiki/Spezial:Weblinksuche/http://wikimedia.org

gets redirected to 

https://de.wikipedia.org/wiki/Spezial:Weblinksuche/https://wikimedia.org

instead of

https://de.wikipedia.org/wiki/Spezial:Weblinksuche/http://wikimedia.org

The protocol part of the search url argument must not be rewritten.
Comment 1 Umherirrender 2014-04-05 19:17:13 UTC
str_replace replaced all instead of the first one. A regex replace with ^ at the begin would help here.

Wiki.php around line 537
$redirUrl = str_replace( 'http://', 'https://', $oldUrl );
Comment 2 Gerrit Notification Bot 2014-04-26 20:35:31 UTC
Change 129925 had a related patch set uploaded by Umherirrender:
http -> https rewrite: Only replace one http by https

https://gerrit.wikimedia.org/r/129925
Comment 3 Gerrit Notification Bot 2014-04-28 19:50:51 UTC
Change 129925 merged by jenkins-bot:
http -> https rewrite: Only replace one http by https

https://gerrit.wikimedia.org/r/129925
Comment 4 Umherirrender 2014-04-28 19:57:49 UTC
successfully merged

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links