Last modified: 2014-07-30 08:19:30 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65614, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 63614 - Error when using rollback on autoreverts
Error when using rollback on autoreverts
Status: RESOLVED WONTFIX
Product: MediaWiki
Classification: Unclassified
History/Diffs (Other open bugs)
1.23.0
All All
: Low normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-04-07 12:30 UTC by Trijnstel
Modified: 2014-07-30 08:19 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Trijnstel 2014-04-07 12:30:35 UTC
When you use rollback on an autorevert (someone who for example vandalises and reverts themselves), it does mark the edits for patrolled but it gives an error that the undo failed. For example on nl.wikipedia on the page "Moeder Teresa" after rollbacking the last two edits of an anon user of today (7 April):
-----
Ongedaan maken van wijzigingen mislukt.

Het is niet mogelijk om de bewerking van de pagina Moeder Teresa door 109.132.6.51 (overleg | bijdragen) ongedaan te maken. Iemand anders heeft deze pagina al bewerkt of hersteld naar een eerdere versie.

De meest recente bewerking is gemaakt door 109.132.6.51 (overleg | bijdragen).
De bewerkingssamenvatting was: "‎Levensloop".
-----
(It says that the rollback faild and that someone "already editted the page or that the page was restored to an earlier version". This is clearly wrong as the edits were patrolled, but the software says an error was made.
Comment 1 Umherirrender 2014-04-07 18:16:17 UTC
Always patrolling a rollback was requested in bug 62157, the error is only shown because you does not produce a new revision (a null edit). This null edit is now detected and the message is shown.
Comment 2 Trijnstel 2014-04-08 09:56:54 UTC
(In reply to Umherirrender from comment #1)
> Always patrolling a rollback was requested in bug 62157, the error is only
> shown because you does not produce a new revision (a null edit). This null
> edit is now detected and the message is shown.

I'm not sure I understand it completely, but this means it's not a bug at all?
Comment 3 Andre Klapper 2014-04-29 14:38:03 UTC
Umherirrender: Could you answer comment 2, please?
Comment 4 Umherirrender 2014-04-29 18:32:32 UTC
(In reply to Trijnstel from comment #2)
> (In reply to Umherirrender from comment #1)
> > Always patrolling a rollback was requested in bug 62157, the error is only
> > shown because you does not produce a new revision (a null edit). This null
> > edit is now detected and the message is shown.
> 
> I'm not sure I understand it completely, but this means it's not a bug at
> all?

I am not sure, which is the best option to have here. Having the message "already rolled" is helpful to have correct feedback for the user, setting patrolling or bot flags for the edits maybe not the best, but that was already there before all the changes. Having no patrolling on error was a feature for user on another wiki, so there seems not best way to have here or only missed documentation of that fact.

You can understand this as feature.
Comment 5 Umherirrender 2014-07-30 08:19:30 UTC
No further response, so marking this as WONTFIX.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links