Last modified: 2014-07-03 15:33:13 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65630, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 63630 - VisualEditor: Pressing Escape or Tab in an empty line inserts pawn symbol (♙) in Opera 12
VisualEditor: Pressing Escape or Tab in an empty line inserts pawn symbol (♙)...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
ContentEditable (Other open bugs)
unspecified
All All
: Normal normal
: VE-deploy-2014-07-03
Assigned To: Bartosz Dziewoński
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-04-07 15:23 UTC by richlv
Modified: 2014-07-03 15:33 UTC (History)
6 users (show)

See Also:
Web browser: Opera
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description richlv 2014-04-07 15:23:24 UTC
visual editor from git f8d56e6804a12248b485c2d3b49d4ff0ffa7220c

edit a page with opera 12.16 on linux, place cursor on an empty line, hit 'esc' - 
symbol ♙ is inserted.

bug #51140 was about this symbol being inserted in a different situation and is supposed to be fixed.

reproducible at https://www.zabbix.org/wiki/Docs/visual_editor_test (if you would like to create a test account, "real name" is mandatory)
Comment 1 richlv 2014-04-07 17:33:28 UTC
(1) another way to get that symbol with opera - hit 'tab' on an empty line.

both of these also "work" in an empty table cell
Comment 2 James Forrester 2014-04-08 02:00:28 UTC
MatmaRex, you still interested in taking on Opera 12 bugs?
Comment 3 Bartosz Dziewoński 2014-04-22 17:36:17 UTC
Yes. I don't have time right now, but I'll try to get around to this sooner or later.
Comment 4 Bartosz Dziewoński 2014-05-09 21:09:12 UTC
So, Opera 12 sends the events for the keypresses of Esc and Tab. These events reach ve.ce.Surface.prototype.onDocumentKeyPress and eventually ve.ce.Surface.prototype.handleInsertion, which decides to insert the pawn, which will not be overwritten because neither Esc not Tab produce any text.

onDocumentKeyPress attempts to filter out non-character keypresses by discarding ones where the charCode is 0; Opera's event for Esc has charCode == 27,
for Tab charCode == 9. I guess other browsers use 0 here for some weird reason and you depend on this behavior.
Comment 5 Bartosz Dziewoński 2014-05-09 21:17:26 UTC
This is probably a regression from 4e377629e39a4af9405a5ea8972bdeb1af37ddf6
(fix for bug 48335).
Comment 6 Ed Sanders 2014-07-01 10:24:39 UTC
Seems like it wouldn't be a problem if you just filtered out those keycodes.
Comment 7 Gerrit Notification Bot 2014-07-01 14:40:51 UTC
Change 143322 had a related patch set uploaded by Bartosz Dziewoński:
ve.ce.Surface: Prevent incorrect pawning in Opera 12

https://gerrit.wikimedia.org/r/143322
Comment 8 Gerrit Notification Bot 2014-07-03 07:08:47 UTC
Change 143322 merged by jenkins-bot:
ve.ce.Surface: Prevent incorrect pawning in Opera 12

https://gerrit.wikimedia.org/r/143322

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links