Last modified: 2014-04-16 17:27:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65658, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 63658 - Edit button throws errors when VisualEditor not installed
Edit button throws errors when VisualEditor not installed
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
alpha (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
: 63736 (view as bug list)
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-04-07 23:32 UTC by Jon
Modified: 2014-04-16 17:27 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Jon 2014-04-07 23:32:16 UTC 

    


      




        
          Comment 1
        

        
          Gerrit Notification Bot

        

        
        

        
          2014-04-07 23:32:45 UTC
        
      





Change 124494 had a related patch set uploaded by Jdlrobson:
Only offer VisualEditor if installed and enabled

https://gerrit.wikimedia.org/r/124494

    


      




        
          Comment 2
        

        
          Gerrit Notification Bot

        

        
        

        
          2014-04-08 17:45:45 UTC
        
      





Change 124494 merged by jenkins-bot:
Only offer VisualEditor if installed and enabled

https://gerrit.wikimedia.org/r/124494

    


      




        
          Comment 3
        

        
          Jon

        

        
        

        
          2014-04-09 16:57:06 UTC
        
      





I had to revert this change... since the code is loaded asynchronously it will always return false.

    


      




        
          Comment 4
        

        
          Jon

        

        
        

        
          2014-04-16 04:27:07 UTC
        
      





*** Bug 63736 has been marked as a duplicate of this bug. ***

    


      




        
          Comment 5
        

        
          Ryan Kaldari

        

        
        

        
          2014-04-16 16:42:26 UTC
        
      





Probably the easiest thing to do would be to just check mw.config.get( 'wgVisualEditorConfig' ). If VisualEditor isn't installed, that will return null.

    


      




        
          Comment 6
        

        
          Gerrit Notification Bot

        

        
        

        
          2014-04-16 16:50:07 UTC
        
      





Change 126672 had a related patch set uploaded by Kaldari:
Make sure VisualEditor is installed before trying to use it

https://gerrit.wikimedia.org/r/126672

    


      




        
          Comment 7
        

        
          Gerrit Notification Bot

        

        
        

        
          2014-04-16 17:27:53 UTC
        
      





Change 126672 merged by jenkins-bot:
Make sure VisualEditor is installed before trying to use it

https://gerrit.wikimedia.org/r/126672

    



  






  


    

      

        

          
            

              Note
              You need to
              log in
              before you can comment on or make changes to this bug.
            

          		
        
 
      

  
        





        




  
  First
  Last
  Prev
  Next
    
  This bug is not in your last
    search results.







			

			
		
		
		
		
		
		
			

				
				
				
				
				

					
Navigation

					

						
					

				

				
				
				
				
				

					
Links