Last modified: 2014-04-11 19:12:47 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65666, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 63666 - VisualEditor: Update integration to cope with the new "view on <repo>" tabs on file pages
VisualEditor: Update integration to cope with the new "view on <repo>" tabs o...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: Normal minor
: VE-deploy-2014-04-17
Assigned To: Alex Monk
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-04-08 09:39 UTC by This, that and the other (TTO)
Modified: 2014-04-11 19:12 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description This, that and the other (TTO) 2014-04-08 09:39:32 UTC
1. Log in at http://en.wikipedia.beta.wmflabs.org
2. Enable VE
3. Visit http://en.wikipedia.beta.wmflabs.org/wiki/File:ButtonsReversed.png
   (or any foreign file with no local description page)

You see the following views (tabs):
    Read
    View on Wikimedia Commons
    Create source
    Add local description ^beta

4. Visit http://en.wikipedia.beta.wmflabs.org/wiki/File:Button_hover.svg
   (or any foreign file with an existing local description page)

You see:
    Read
    View on Wikimedia Commons
    Edit source
    Edit local description ^beta
    View history

The tab name "Create/Edit source" does not sit well next to "Add/Edit local description ^beta". The wikitext-editing tab needs a better name when viewing foreign files.

Admittedly these tabs were altered in core [1] without consulting the VE people, but of course, it is the responsibility of extension authors to catch up to new core functionality.

[1] Gerrit change #104182
Comment 1 James Forrester 2014-04-08 18:15:48 UTC
Sorry that we missed this.

BTW, changes to major MediaWiki semantics (even good ones like this) should really be highlighted on wikitech-l and/or ideally design-l before being implemented and merged. I have a bunch of ideas about how this could have been done more cleanly that it's now too late to try out. :-(
Comment 2 Alex Monk 2014-04-08 19:31:03 UTC
So "Edit source" or "Create source" should become "Edit local description source" or "Add local description source" on file description pages for files in foreign repositories?
Comment 3 This, that and the other (TTO) 2014-04-08 21:48:08 UTC
(In reply to Alex Monk from comment #2)
> So "Edit source" or "Create source" should become "Edit local description
> source" or "Add local description source" on file description pages for
> files in foreign repositories?

I guess. It's verbose, but then that's really my fault...
Comment 4 Gerrit Notification Bot 2014-04-08 23:12:27 UTC
Change 124775 had a related patch set uploaded by Alex Monk:
Use updated tab labels on description pages for files in foreign repos

https://gerrit.wikimedia.org/r/124775
Comment 5 Gerrit Notification Bot 2014-04-11 19:11:12 UTC
Change 124775 merged by jenkins-bot:
Use updated tab labels on description pages for files in foreign repos

https://gerrit.wikimedia.org/r/124775

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links