Last modified: 2014-04-16 17:27:51 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65689, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 63689 - When VisualEditor not available, wikitext editor still shows a edit switcher button in toolbar
When VisualEditor not available, wikitext editor still shows a edit switcher ...
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
alpha (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-04-08 17:44 UTC by Jon
Modified: 2014-04-16 17:27 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jon 2014-04-08 17:44:52 UTC
To replicate:
Disable VisualEditor and load the editor. Wikitext editor loads but according to toolbar VisualEditor is available.
Comment 1 Bingle 2014-04-08 17:45:10 UTC
Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1913
Comment 2 Ryan Kaldari 2014-04-16 03:51:14 UTC
I can't replicate this. If I disable the VisualEditor and try to load the editor in Alpha mode, the editor won't even load. It gives me an unknown dependency JS error. Looking at the code in editor.js, it doesn't look like it takes into account the possibility of the VisualEditor being disabled (which should probably be filed as a different bug).

If you can replicate this, please post more detailed replication steps.
Comment 3 Theopolisme 2014-04-16 04:03:57 UTC
(In reply to Ryan Kaldari from comment #2)

> I can't replicate this. If I disable the VisualEditor and try to load the
> editor in Alpha mode, the editor won't even load. It gives me an unknown
> dependency JS error. Looking at the code in editor.js, it doesn't look like
> it takes into account the possibility of the VisualEditor being disabled
> (which should probably be filed as a different bug).

This. x1000.

I brought this up as a comment on a patch in Gerrit[1], along with a possible solution, but there were never any replies.

Right now MobileFrontend editing does not work on non-VE-enabled websites... which includes my dev site :P

Probably worthy of a bug...

[1] https://gerrit.wikimedia.org/r/#/c/124881/
Comment 4 Jon 2014-04-16 04:22:30 UTC
sorry Theo! I missed that. I don't follow comments on merged commits. Can you bring up your questions on bug 63736 and I'll do my best to answer them in next 24hrs!

Ryan see Bug: 63736 this bug was raised after a fix for it was merged that had to be reverted :(
Comment 5 Gerrit Notification Bot 2014-04-16 16:50:02 UTC
Change 126672 had a related patch set uploaded by Kaldari:
Make sure VisualEditor is installed before trying to use it

https://gerrit.wikimedia.org/r/126672
Comment 6 Gerrit Notification Bot 2014-04-16 17:27:51 UTC
Change 126672 merged by jenkins-bot:
Make sure VisualEditor is installed before trying to use it

https://gerrit.wikimedia.org/r/126672

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links