Last modified: 2014-05-06 23:02:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65699, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 63699 - Parsoid and Tidy differ in how they deal with misnested tags
Parsoid and Tidy differ in how they deal with misnested tags
Status: NEW
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Gabriel Wicke
https://www.mediawiki.org/wiki/User:S...
:
: 63798 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-04-08 20:28 UTC by spage
Modified: 2014-05-06 23:02 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description spage 2014-04-08 20:28:47 UTC
I edited https://www.mediawiki.org/w/index.php?title=MediaWiki-Vagrant&oldid=946962 with VisualEditor.  Everything after the "Quick Start" section appeared in monospace.

I repro'd with the smaller test page https://www.mediawiki.org/wiki/User:S_Page_(WMF)/VE_span_bug

I think the issue lies in

 <p style="font-size: 1.2em; margin-top: 1.2em;">When Vagrant is done configuring your machine, browse to <span class=plainlinks>http://127.0.0.1:8080/</span> to find your MediaWiki instance. The admin password is <code>vagrant<code>.</span>

Note its incorrect second opening <code> instead of closing the code, and a second closing </span>. Yet regular wiki parsing can handle it.
Comment 1 ssastry 2014-04-08 20:55:20 UTC
(In reply to spage from comment #0)
 
> Note its incorrect second opening <code> instead of closing the code, and a
> second closing </span>. Yet regular wiki parsing can handle it.

This is Tidy doing the cleanup. PHP parser does not do the fixup automatically. This is a known issue -- we have a bunch of these scenarios now where Parsoid and Tidy fixup broken code differently. We'll never match Tidy behavior (which is not always the desired behavior in any case). But, as for this specific scenario, fixing this will require us to use heuristics in the tokenizer and more complexity. At this time, it is not clear if the additional complexity is worth it, except for easy to auto-fix scenarios.
Comment 2 ssastry 2014-05-06 23:02:10 UTC
*** Bug 63798 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links