Last modified: 2014-06-30 13:45:14 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65716, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 63716 - [News] extension fails on 1.22. Feed page says "no feed found on page"
[News] extension fails on 1.22. Feed page says "no feed found on page"
Status: UNCONFIRMED
Product: MediaWiki extensions
Classification: Unclassified
Other (Other open bugs)
REL1_22-branch
PC Linux
: Low blocker (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-04-09 01:04 UTC by richard-oss
Modified: 2014-06-30 13:45 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description richard-oss 2014-04-09 01:04:07 UTC
Upgrading to MediaWiki 1.22.4, and the News extension stopped working.

The tag I use is <newsfeed>. The feed content renders fine in the page, but when following the <newsfeedlink> I get a page with the following:

"<h1>Not Found</h1><p>no feed found on page: [my feed name]</p>"

Others report the problem here:
https://www.mediawiki.org/wiki/Extension_talk:News#no_feed_found_on_page:

The suggested workaround is to change lines 53-54 of NewsRenderer.php from
                $article->getContent();
                $text = $article->mContent;
To
                $text = $article->getContent();

I can confirm this works, but the documentation warns that Article::getContent is deprecated, and that it has side effects.
Comment 1 richard-oss 2014-04-09 01:04:39 UTC
I tried:
                $page = $article->getPage();
                $text = $page->getContent();
But the data structure isn't right, so nothing is returned.
Comment 2 Andre Klapper 2014-04-09 10:53:02 UTC
Extension doesn't look too maintained to me.
Comment 3 richard-oss 2014-04-09 23:03:06 UTC
I think the long term fix is to adapt the parser to the result of WikiPage->getContent(), but I don't have a MediaWiki development environment and I am having a hard time seeing what is returned from tha call.

It is interesting that the feed content is correctly displayed on the wiki page with the <newsfeed> tag. If I can identify where that is happening, I can try to use the same process here. There should probably be a single function to do it for both places, and then hand them to different formatting functions for the display. I'm not clear on how much work the parser is doing.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links