Last modified: 2014-11-12 15:04:22 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65723, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 63723 - Time formatting incorrect for some languages
Time formatting incorrect for some languages
Status: REOPENED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: Highest major (vote)
: ---
Assigned To: Wikidata bugs
u=dev c=backend p=20 s=2014-04-23
:
: 63735 (view as bug list)
Depends on: 63733
Blocks:
  Show dependency treegraph
 
Reported: 2014-04-09 11:38 UTC by Addshore
Modified: 2014-11-12 15:04 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Addshore 2014-04-09 11:38:57 UTC
Since we now take language into account when formatting times the one remaining part of the old formatter now has a bug. Specifically the two regexes in MwTimeIsoFormatter::getDateFormat().

As we not use more languages we also have to take into account more tokens to remove for months and days!
Comment 1 Gerrit Notification Bot 2014-04-09 11:39:34 UTC
Change 124823 had a related patch set uploaded by Addshore:
Correctly format dates for lang=nl

https://gerrit.wikimedia.org/r/124823
Comment 2 Addshore 2014-04-09 12:01:37 UTC
This is broken for 164 out of 397 languages: List to come...
Comment 3 Gerrit Notification Bot 2014-04-09 12:06:15 UTC
Change 124823 merged by jenkins-bot:
Correctly format dates for lang=nl

https://gerrit.wikimedia.org/r/124823
Comment 4 Addshore 2014-04-09 12:18:50 UTC
Affected Langs:
		$brokenLanguages = array(
			'ab', 'als', 'anp', 'ar', 'arq', 'arz', 'as', 'av', 'azb',
			'ba', 'bar', 'bcc', 'be', 'be-tarask', 'be-x-old', 'bh', 'bho', 'bn', 'bo', 'bpy', 'bqi', 'bxr',
			'cdo', 'ce', 'ckb', 'crh', 'crh-latn', 'crh-cyrl', 'cs', 'cu', 'cv',
			'da', 'de', 'de-at', 'de-ch', 'de-formal', 'dsb', 'dz',
			'el', 'eo', 'et',
			'fa', 'fi', 'fit', 'fiu-vro', 'fo', 'frr', 'fur',
			'gan', 'gan-hans', 'gan-hant', 'gl', 'glk', 'grc', 'gsw', 'gu',
			'he', ' hi', ' hr', ' hrx', ' hsb', ' hu', ' hy',
			'ii', ' inh', ' is',
			'ja', ' jut',
			'kaa', 'kk', 'kk-arab', 'kk-cyrl', 'kk-latn', 'kk-cn', 'kk-kz', 'kk-tr', 'kl', 'km', 'kn',
			'ko', 'ko-kp', 'koi', 'krc', 'ks', 'ks-arab', 'ks-deva', 'ksh', 'ku-arab', 'kv',
			'la', 'lb', 'lbe', 'lez', 'liv', 'lo', 'lzh',
			'mai', 'mhr', 'mr', 'mrj', 'mwl', 'my', 'myv', 'mzn',
			'nan', 'nb', 'nds', 'ne', 'new', 'nn', 'no',
			'oc', 'or', 'os',
			'pa', 'pdc', 'pdt', 'pi', 'pnt', 'pt', 'pt-br',
			'ru', 'rue',
			'sa', 'sah', 'sk', 'sl', 'sli', 'sr', 'sr-ec', 'sr-el', 'stq',
			'tcy', 'tg', 'tg-cyrl', 'th', 'tyv',
			'udm', 'uk', 'uz',
			'vep', 'vi', 'vmf', 'vo', 'vot', 'vro',
			'wuu',
			'xal',
			'yi', 'yue',
			'za', 'za', 'zh-classical', 'zh-cn', 'zh-hans', 'zh-hant', 'zh-hk', 'zh-min-nan', 'zh-mo',
			'zh-my', 'zh-sg', 'zh-tw', 'zh-yue'
		);
Comment 5 Gerrit Notification Bot 2014-04-09 13:04:48 UTC
Change 124824 had a related patch set uploaded by Addshore:
Add tests for formatting dates in different langs

https://gerrit.wikimedia.org/r/124824
Comment 6 Gerrit Notification Bot 2014-04-09 13:06:27 UTC
Change 124833 had a related patch set uploaded by Addshore:
Stop ALWAYS usign regex to fix dateFormats

https://gerrit.wikimedia.org/r/124833
Comment 7 Gerrit Notification Bot 2014-04-09 13:22:37 UTC
Change 124836 had a related patch set uploaded by Addshore:
DNM WIP Fix formatting in various languages

https://gerrit.wikimedia.org/r/124836
Comment 8 Lydia Pintscher 2014-04-09 16:07:01 UTC
*** Bug 63735 has been marked as a duplicate of this bug. ***
Comment 9 Gerrit Notification Bot 2014-04-10 12:13:08 UTC
Change 125177 had a related patch set uploaded by Addshore:
When precision is a <= year use 'Y' dateformat

https://gerrit.wikimedia.org/r/125177
Comment 10 Gerrit Notification Bot 2014-04-11 12:31:09 UTC
Change 124824 merged by jenkins-bot:
Add tests for formatting dates in different langs

https://gerrit.wikimedia.org/r/124824
Comment 11 Gerrit Notification Bot 2014-04-11 13:28:17 UTC
Change 125177 abandoned by Addshore:
When precision is a <= year use 'Y' dateformat

https://gerrit.wikimedia.org/r/125177
Comment 12 Gerrit Notification Bot 2014-04-11 13:28:40 UTC
Change 124833 abandoned by Addshore:
Stop ALWAYS using regex to fix dateFormats

Reason:
See https://gerrit.wikimedia.org/r/124836

https://gerrit.wikimedia.org/r/124833
Comment 13 Gerrit Notification Bot 2014-04-15 15:45:41 UTC
Change 124836 merged by jenkins-bot:
Fix formatting dates in most languages

https://gerrit.wikimedia.org/r/124836
Comment 14 tobias.gritschacher 2014-04-23 15:34:15 UTC
Looking at the last patch-set it seems only the languages 'lzh' and 'zh-classical' are left.
Comment 15 Addshore 2014-04-23 16:34:16 UTC
Indeed!
Comment 16 Gerrit Notification Bot 2014-04-24 03:10:30 UTC
Change 129370 had a related patch set uploaded by Aude:
Remove skip tests in MwTimeIsoFormatterTest

https://gerrit.wikimedia.org/r/129370
Comment 17 Gerrit Notification Bot 2014-04-25 10:48:58 UTC
Change 129370 merged by jenkins-bot:
Remove skip tests in MwTimeIsoFormatterTest

https://gerrit.wikimedia.org/r/129370
Comment 18 JulesWinnfield-hu 2014-11-12 14:52:16 UTC
Date format for Hungarian is broken.
Instead of "1970. január 1." it is "1 január 1970" This is also valid for the {{#property}} parser function on huwiki. It was fine in November 2013. Why it has changed?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links