Last modified: 2014-09-15 15:31:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65726, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 63726 - [time ui] years like 1400 are added with precision=7 (century)
[time ui] years like 1400 are added with precision=7 (century)
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: High major with 1 vote (vote)
: ---
Assigned To: Wikidata bugs
u=dev c=backend p=0
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-04-09 13:29 UTC by FelixReimann
Modified: 2014-09-15 15:31 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description FelixReimann 2014-04-09 13:29:38 UTC
- Add year "1400" in the UI
- You will see "14. century"
- Change auto-detected precision from century to year in "advanced adjustments"
- You still see "14. century"
- Click save
- Date is saved as +00000001400-01-01T00:00:00Z precision 7 (century)

https://www.wikidata.org/w/index.php?title=Q3907398&action=historysubmit&diff=119811305&oldid=119811153
Comment 1 Thiemo Mättig 2014-06-10 20:20:25 UTC
The first problem should have been fixed for a while now. I can't reproduce it at wikidata.org. The auto-detection does not set "century" any more. "1400" is auto-detected as "year". Please try to clean your browser caches.

I can reproduce the second problem. But I'm not sure if it's a bug we can fix. The problem is: The text field contains "14. century". What should happen if you set the precision to "year" but the text field still contains "14. century"? This is a mismatch. The current implementation takes the value of the text field more serious. Should the UI really touch what you typed when you change the precision? I'm afraid this will lead to all kinds of other problems.

Current solution: Delete the value and type "1400" again. The precision will be set to "year".

I will left this bug open because the current behavior really is a bit confusing and we should try to think of a solution. Suggestions welcome.
Comment 2 John Mark Vandenberg 2014-06-10 21:32:52 UTC
The user input was '1400'. The UI should keep that literal string in its memory and apply the precision changes to that string to obtain the derived value, until the user changes the input box.
Comment 3 Thiemo Mättig 2014-06-11 09:03:04 UTC
(In reply to John Mark Vandenberg from comment #2)
> The user input was '1400'.

If you look at the two situations independently this is not how it works. The second situation is exactly like you typed "14. century". Try it: Type "14. century". The precision will be auto-detected as "century". This is correct, right? Now try to change the precision to "year". What do you expect?

I'm thinking about the following change: When clicking "edit" the input field should not contain "14. century" but "1400" with the precision set to "century". Basically: Limit the precision of the editable value to "max. year". Unfortunately I'm not sure if this is an easy fix. It might need an additional API request.

Additionally the precision selector should be expanded automatically when the precision is not "year".
Comment 4 Lydia Pintscher 2014-09-15 15:31:38 UTC
I am going to close this as the first issue is fixed and I don't see us being able to solve the other one in the foreseeable future.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links