Last modified: 2014-08-26 17:02:22 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65742, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 63742 - Make the app pass checkstyle cleanly
Make the app pass checkstyle cleanly
Status: RESOLVED FIXED
Product: Wikipedia App
Classification: Unclassified
Automated Builds (Other open bugs)
Android (alpha)
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-04-09 19:24 UTC by Yuvi Panda
Modified: 2014-08-26 17:02 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Yuvi Panda 2014-04-09 19:24:29 UTC
Currently plenty of errors abound.
Comment 1 Gerrit Notification Bot 2014-04-09 19:24:56 UTC
Change 124914 had a related patch set uploaded by Yuvipanda:
Remove sole tab character

https://gerrit.wikimedia.org/r/124914
Comment 2 Gerrit Notification Bot 2014-04-09 19:35:38 UTC
Change 124917 had a related patch set uploaded by Yuvipanda:
Fix ordering of visibility modifiers to match JLS

https://gerrit.wikimedia.org/r/124917
Comment 3 Gerrit Notification Bot 2014-04-09 19:39:27 UTC
Change 124961 had a related patch set uploaded by Yuvipanda:
Organize imports & remove a redundant import

https://gerrit.wikimedia.org/r/124961
Comment 4 Gerrit Notification Bot 2014-04-09 19:40:32 UTC
Change 124976 had a related patch set uploaded by Yuvipanda:
Explicitly use braces everywhere

https://gerrit.wikimedia.org/r/124976
Comment 5 Gerrit Notification Bot 2014-04-09 19:42:31 UTC
Change 124983 had a related patch set uploaded by Yuvipanda:
Use Java style array declarations than C style

https://gerrit.wikimedia.org/r/124983
Comment 6 Gerrit Notification Bot 2014-04-09 19:48:22 UTC
Change 124986 had a related patch set uploaded by Yuvipanda:
Properly format multiline boolean checks to be more consistent

https://gerrit.wikimedia.org/r/124986
Comment 7 Gerrit Notification Bot 2014-04-09 19:49:39 UTC
Change 124987 had a related patch set uploaded by Yuvipanda:
Ensure that Utils class can't be instantiated

https://gerrit.wikimedia.org/r/124987
Comment 8 Gerrit Notification Bot 2014-04-09 19:50:45 UTC
Change 124988 had a related patch set uploaded by Yuvipanda:
Make sure that all member variables are camelCase

https://gerrit.wikimedia.org/r/124988
Comment 9 Gerrit Notification Bot 2014-04-09 19:54:34 UTC
Change 124992 had a related patch set uploaded by Yuvipanda:
Remove space inside array initializers

https://gerrit.wikimedia.org/r/124992
Comment 10 Gerrit Notification Bot 2014-04-09 19:58:43 UTC
Change 124996 had a related patch set uploaded by Yuvipanda:
Remove redundant public and static modifiers

https://gerrit.wikimedia.org/r/124996
Comment 11 Gerrit Notification Bot 2014-04-09 20:17:39 UTC
Change 125000 had a related patch set uploaded by Yuvipanda:
Ensure that all constants are named ALL_UPPERCASE

https://gerrit.wikimedia.org/r/125000
Comment 12 Gerrit Notification Bot 2014-04-09 20:19:03 UTC
Change 125001 had a related patch set uploaded by Yuvipanda:
Remove stray spaces inside parens

https://gerrit.wikimedia.org/r/125001
Comment 13 Gerrit Notification Bot 2014-04-09 20:21:01 UTC
Change 125002 had a related patch set uploaded by Yuvipanda:
Ensure that there is always a space after a comma

https://gerrit.wikimedia.org/r/125002
Comment 14 Gerrit Notification Bot 2014-04-09 20:24:43 UTC
Change 125003 had a related patch set uploaded by Yuvipanda:
Check that static variables are always all caps

https://gerrit.wikimedia.org/r/125003
Comment 15 Gerrit Notification Bot 2014-04-10 00:20:51 UTC
Change 124914 merged by jenkins-bot:
Remove sole tab character

https://gerrit.wikimedia.org/r/124914
Comment 16 Gerrit Notification Bot 2014-04-10 00:21:31 UTC
Change 124917 merged by jenkins-bot:
Fix ordering of visibility modifiers to match JLS

https://gerrit.wikimedia.org/r/124917
Comment 17 Gerrit Notification Bot 2014-04-10 09:29:56 UTC
Change 125002 merged by jenkins-bot:
Ensure that there is always a space after a comma

https://gerrit.wikimedia.org/r/125002
Comment 18 Gerrit Notification Bot 2014-04-10 09:31:39 UTC
Change 124961 merged by jenkins-bot:
Organize imports & remove a redundant import

https://gerrit.wikimedia.org/r/124961
Comment 19 Gerrit Notification Bot 2014-04-10 09:31:42 UTC
Change 124976 merged by jenkins-bot:
Explicitly use braces everywhere

https://gerrit.wikimedia.org/r/124976
Comment 20 Gerrit Notification Bot 2014-04-10 09:37:51 UTC
Change 124983 merged by jenkins-bot:
Use Java style array declarations than C style

https://gerrit.wikimedia.org/r/124983
Comment 21 Gerrit Notification Bot 2014-04-10 09:37:53 UTC
Change 124986 merged by jenkins-bot:
Properly format multiline boolean checks to be more consistent

https://gerrit.wikimedia.org/r/124986
Comment 22 Gerrit Notification Bot 2014-04-10 09:37:56 UTC
Change 124987 merged by jenkins-bot:
Ensure that Utils class can't be instantiated

https://gerrit.wikimedia.org/r/124987
Comment 23 Gerrit Notification Bot 2014-04-10 09:37:59 UTC
Change 124988 merged by jenkins-bot:
Make sure that all member variables are camelCase

https://gerrit.wikimedia.org/r/124988
Comment 24 Gerrit Notification Bot 2014-04-10 09:38:18 UTC
Change 124992 merged by jenkins-bot:
Remove space inside array initializers

https://gerrit.wikimedia.org/r/124992
Comment 25 Gerrit Notification Bot 2014-04-10 09:38:21 UTC
Change 124996 merged by jenkins-bot:
Remove redundant public and static modifiers

https://gerrit.wikimedia.org/r/124996
Comment 26 Gerrit Notification Bot 2014-04-10 09:38:24 UTC
Change 125000 merged by jenkins-bot:
Ensure that all constants are named ALL_UPPERCASE

https://gerrit.wikimedia.org/r/125000
Comment 27 Gerrit Notification Bot 2014-04-10 09:38:26 UTC
Change 125001 merged by jenkins-bot:
Remove stray spaces inside parentheses

https://gerrit.wikimedia.org/r/125001
Comment 28 Gerrit Notification Bot 2014-04-10 09:38:59 UTC
Change 125003 merged by jenkins-bot:
Check that static variables are always all caps

https://gerrit.wikimedia.org/r/125003
Comment 29 Gerrit Notification Bot 2014-04-10 09:41:38 UTC
Change 125109 had a related patch set uploaded by Yuvipanda:
Fix checkstyle.xml to allow underscores in static var names

https://gerrit.wikimedia.org/r/125109
Comment 30 Gerrit Notification Bot 2014-04-10 09:44:59 UTC
Change 125110 had a related patch set uploaded by Yuvipanda:
Fix static variable names

https://gerrit.wikimedia.org/r/125110
Comment 31 Gerrit Notification Bot 2014-04-10 09:47:13 UTC
Change 125111 had a related patch set uploaded by Yuvipanda:
Neuter stray whitespace before semicolon

https://gerrit.wikimedia.org/r/125111
Comment 32 Gerrit Notification Bot 2014-04-10 09:48:47 UTC
Change 125112 had a related patch set uploaded by Yuvipanda:
Remove redundant 'final' qualifiers

https://gerrit.wikimedia.org/r/125112
Comment 33 Gerrit Notification Bot 2014-04-10 09:48:50 UTC
Change 125109 merged by jenkins-bot:
Fix checkstyle.xml to allow underscores in static var names

https://gerrit.wikimedia.org/r/125109
Comment 34 Gerrit Notification Bot 2014-04-10 09:50:52 UTC
Change 125110 merged by jenkins-bot:
Fix static variable names

https://gerrit.wikimedia.org/r/125110
Comment 35 Gerrit Notification Bot 2014-04-10 09:51:04 UTC
Change 125111 merged by jenkins-bot:
Neuter stray whitespace before semicolon

https://gerrit.wikimedia.org/r/125111
Comment 36 Gerrit Notification Bot 2014-04-10 09:51:53 UTC
Change 125114 had a related patch set uploaded by Yuvipanda:
Remove redundant 'final' qualifiers

https://gerrit.wikimedia.org/r/125114
Comment 37 Gerrit Notification Bot 2014-04-10 09:52:53 UTC
Change 125115 had a related patch set uploaded by Yuvipanda:
Fix wider-than-necessary visibility

https://gerrit.wikimedia.org/r/125115
Comment 38 Gerrit Notification Bot 2014-04-10 09:53:06 UTC
Change 125112 abandoned by Addshore:
Remove redundant 'final' qualifiers

Reason:
I live here now https://gerrit.wikimedia.org/r/#/c/125114/

https://gerrit.wikimedia.org/r/125112
Comment 39 Gerrit Notification Bot 2014-04-10 09:54:25 UTC
Change 125114 merged by jenkins-bot:
Remove redundant 'final' qualifiers

https://gerrit.wikimedia.org/r/125114
Comment 40 Gerrit Notification Bot 2014-04-10 09:59:08 UTC
Change 125119 had a related patch set uploaded by Yuvipanda:
Allow inline conditionals.

https://gerrit.wikimedia.org/r/125119
Comment 41 Gerrit Notification Bot 2014-04-10 10:17:18 UTC
Change 125115 merged by jenkins-bot:
Fix wider-than-necessary visibility

https://gerrit.wikimedia.org/r/125115
Comment 42 Gerrit Notification Bot 2014-04-10 10:17:21 UTC
Change 125119 merged by jenkins-bot:
Allow inline conditionals.

https://gerrit.wikimedia.org/r/125119
Comment 43 Gerrit Notification Bot 2014-04-15 19:57:55 UTC
Change 126068 had a related patch set uploaded by Yuvipanda:
Do not enforce spacing around curly braces

https://gerrit.wikimedia.org/r/126068
Comment 44 Gerrit Notification Bot 2014-04-15 20:07:46 UTC
Change 126068 merged by jenkins-bot:
Do not enforce spacing around curly braces

https://gerrit.wikimedia.org/r/126068
Comment 45 Gerrit Notification Bot 2014-04-15 20:08:38 UTC
Change 126086 had a related patch set uploaded by Yuvipanda:
Fix checkstyle.xml to work on older checkstyles

https://gerrit.wikimedia.org/r/126086
Comment 46 Gerrit Notification Bot 2014-04-15 20:11:49 UTC
Change 126086 merged by jenkins-bot:
Fix checkstyle.xml to work on older checkstyles

https://gerrit.wikimedia.org/r/126086
Comment 47 Gerrit Notification Bot 2014-04-15 20:15:10 UTC
Change 126112 had a related patch set uploaded by Yuvipanda:
Add spaces where required to match checkstyle.

https://gerrit.wikimedia.org/r/126112
Comment 48 Gerrit Notification Bot 2014-04-15 20:16:48 UTC
Change 126113 had a related patch set uploaded by Yuvipanda:
Fix ordering of class definition modifier

https://gerrit.wikimedia.org/r/126113
Comment 49 Gerrit Notification Bot 2014-04-15 20:17:51 UTC
Change 126114 had a related patch set uploaded by Yuvipanda:
Rename static variables to match ALL_CAPS_SHOUT

https://gerrit.wikimedia.org/r/126114
Comment 50 Gerrit Notification Bot 2014-04-15 20:22:44 UTC
Change 126116 had a related patch set uploaded by Yuvipanda:
Make sure all switches have a default case

https://gerrit.wikimedia.org/r/126116
Comment 51 Gerrit Notification Bot 2014-04-15 20:27:06 UTC
Change 126112 merged by Brion VIBBER:
Add spaces where required to match checkstyle.

https://gerrit.wikimedia.org/r/126112
Comment 52 Gerrit Notification Bot 2014-04-15 20:27:21 UTC
Change 126113 merged by Brion VIBBER:
Fix ordering of class definition modifier

https://gerrit.wikimedia.org/r/126113
Comment 53 Gerrit Notification Bot 2014-04-15 20:28:54 UTC
Change 126120 had a related patch set uploaded by Yuvipanda:
Ignore setter and constructors for HiddenFieldCheck

https://gerrit.wikimedia.org/r/126120
Comment 54 Gerrit Notification Bot 2014-04-15 20:45:47 UTC
Change 126128 had a related patch set uploaded by Yuvipanda:
Don't count blocks as empty if they have comments in them

https://gerrit.wikimedia.org/r/126128
Comment 55 Gerrit Notification Bot 2014-04-15 20:49:56 UTC
Change 126129 had a related patch set uploaded by Yuvipanda:
Mark some uninheritable classes as final

https://gerrit.wikimedia.org/r/126129
Comment 56 Gerrit Notification Bot 2014-04-15 21:14:46 UTC
Change 126116 merged by jenkins-bot:
Make sure all switches have a default case

https://gerrit.wikimedia.org/r/126116
Comment 57 Gerrit Notification Bot 2014-04-15 21:14:49 UTC
Change 126120 merged by Brion VIBBER:
Ignore setter and constructors for HiddenFieldCheck

https://gerrit.wikimedia.org/r/126120
Comment 58 Gerrit Notification Bot 2014-04-15 21:30:29 UTC
Change 126135 had a related patch set uploaded by Yuvipanda:
Refine Magic Number detection to ignore common numbers

https://gerrit.wikimedia.org/r/126135
Comment 59 Gerrit Notification Bot 2014-04-15 22:56:58 UTC
Change 126156 had a related patch set uploaded by Yuvipanda:
Fix FieldHidden warnings & turn off warnings for params

https://gerrit.wikimedia.org/r/126156
Comment 60 Gerrit Notification Bot 2014-04-15 23:09:09 UTC
Change 126128 merged by Brion VIBBER:
Don't count blocks as empty if they have comments in them

https://gerrit.wikimedia.org/r/126128
Comment 61 Gerrit Notification Bot 2014-04-15 23:10:03 UTC
Change 126129 merged by Brion VIBBER:
Mark some uninheritable classes as final

https://gerrit.wikimedia.org/r/126129
Comment 62 Gerrit Notification Bot 2014-04-15 23:10:45 UTC
Change 126135 merged by Brion VIBBER:
Refine Magic Number detection to ignore common numbers

https://gerrit.wikimedia.org/r/126135
Comment 63 Gerrit Notification Bot 2014-04-16 13:00:14 UTC
Change 126237 had a related patch set uploaded by Yuvipanda:
Make magic numbers unmagical

https://gerrit.wikimedia.org/r/126237
Comment 64 Gerrit Notification Bot 2014-04-16 17:34:20 UTC
Change 126156 merged by Brion VIBBER:
Fix FieldHidden warnings & turn off warnings for params

https://gerrit.wikimedia.org/r/126156
Comment 65 Gerrit Notification Bot 2014-04-16 17:48:56 UTC
Change 126237 merged by Brion VIBBER:
Make magic numbers unmagical

https://gerrit.wikimedia.org/r/126237
Comment 66 Yuvi Panda 2014-04-16 17:50:25 UTC
Down to 50 errors!!1
Comment 67 Gerrit Notification Bot 2014-05-20 14:52:12 UTC
Change 134365 had a related patch set uploaded by Anirudh24seven:
Move + symbols to the next line. This will fix the OperatorWrapCheck warning.

https://gerrit.wikimedia.org/r/134365
Comment 68 Gerrit Notification Bot 2014-05-20 15:15:12 UTC
Change 134365 merged by jenkins-bot:
Move + symbols to the next line. This will fix the OperatorWrapCheck warning.

https://gerrit.wikimedia.org/r/134365
Comment 69 Gerrit Notification Bot 2014-05-20 16:42:41 UTC
Change 134382 had a related patch set uploaded by Anirudh24seven:
Use Java-style Array brackets

https://gerrit.wikimedia.org/r/134382
Comment 70 Gerrit Notification Bot 2014-05-20 17:29:52 UTC
Change 134381 had a related patch set uploaded by Yuvipanda:
Remove unused imports

https://gerrit.wikimedia.org/r/134381
Comment 71 Gerrit Notification Bot 2014-05-20 18:44:18 UTC
Change 134381 merged by jenkins-bot:
Remove unused imports

https://gerrit.wikimedia.org/r/134381
Comment 72 Gerrit Notification Bot 2014-05-20 18:44:22 UTC
Change 134382 merged by jenkins-bot:
Use Java-style Array brackets

https://gerrit.wikimedia.org/r/134382
Comment 73 Gerrit Notification Bot 2014-08-26 17:02:22 UTC
Change 126114 abandoned by Dbrant:
Rename static variables to match ALL_CAPS_SHOUT

https://gerrit.wikimedia.org/r/126114

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links