Last modified: 2014-04-10 19:19:33 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65780, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 63780 - login broken on beta labs
login broken on beta labs
Status: RESOLVED FIXED
Product: Wikimedia Labs
Classification: Unclassified
deployment-prep (beta) (Other open bugs)
unspecified
All All
: High major
: ---
Assigned To: Ori Livneh
: browser-test-bug
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-04-10 16:50 UTC by Chris McMahon
Modified: 2014-04-10 19:19 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Chris McMahon 2014-04-10 16:50:26 UTC
On http://en.wikipedia.beta.wmflabs.org/ attempt to login

Upon logging in, the resulting URL contains "$channel" instead of "beta" and browser shows no page

result: 
http://en.wikipedia.%24channel.wmflabs.org/wiki/Special:CentralLogin/complete?token=fba1899f0e1715c2a585874c3c47812d

http://en.wikipedia.$channel.wmflabs.org is also seen. 

Login seems to succeed.

This prevents any automated test that logs in from running.
Comment 1 Bryan Davis 2014-04-10 17:07:21 UTC
This may have been caused by https://gerrit.wikimedia.org/r/#/c/125062/ and https://gerrit.wikimedia.org/r/#/c/125070/.
Comment 2 Gerrit Notification Bot 2014-04-10 19:14:48 UTC
Change 125264 had a related patch set uploaded by Ori.livneh:
Work around bug 63780 by specifying a siteParamsCallback

https://gerrit.wikimedia.org/r/125264
Comment 3 Gerrit Notification Bot 2014-04-10 19:15:37 UTC
Change 125264 merged by Ori.livneh:
Work around bug 63780 by specifying a siteParamsCallback

https://gerrit.wikimedia.org/r/125264
Comment 4 Ori Livneh 2014-04-10 19:19:33 UTC
When siteParamsCallback is called for 'enwiki', it doesn't know whether the configuration values it should return are the HHVM ones or not, so this workaround will have the effect of redirecting users on beta-hhvm to beta on login. So I'll have to figure out a better solution at some point. For now, though, this does unbreak testing on beta, which doesn't care / know about beta-hhvm.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links