Last modified: 2014-09-01 12:40:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65789, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 63789 - Flow: anonymous users don't see any replies to a hidden comment
Flow: anonymous users don't see any replies to a hidden comment
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
master
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
https://www.mediawiki.org/w/index.php...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-04-10 20:27 UTC by spage
Modified: 2014-09-01 12:40 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description spage 2014-04-10 20:27:29 UTC
If a top-level comment is hidden, an anonymous user doesn't see any of the replies to it.  This is really confusing when there's only one top-level comment: the entire topic appears empty to anonymous users with no indication why, despite "4 comments" (see URL in bug).

To reproduce, start a new topic with one top-level comment, make tons of replies to it, then hide it.

This is similar to bug 63657.

One part of the fix: If some of the posts under a topic aren't visible to the current user, change the flow-topic-comments to "4* comments" with an asterisk and give it a title tooltip saying "4 comments, some not shown". I'll file a separate bug.
Comment 1 spage 2014-04-10 20:37:12 UTC
> If some of the posts under a topic aren't visible to the current user,
> change the flow-topic-comments to "4* comments" with an asterisk...

I suggested this in bug 60491 comment #2.
Comment 2 Maryana Pinchuk 2014-04-15 18:25:55 UTC
The fix should simply be to show hidden topics/posts to everyone, not just logged in users. I'm not even sure why we implemented it this way originally!
Comment 3 Gerrit Notification Bot 2014-05-19 16:25:18 UTC
Change 134109 had a related patch set uploaded by Matthias Mullie:
(bug 63789) anonymous users don't see any replies to a hidden comment

https://gerrit.wikimedia.org/r/134109
Comment 4 Gerrit Notification Bot 2014-05-23 20:31:11 UTC
Change 134109 merged by jenkins-bot:
(bug 63789) anonymous users don't see any replies to a hidden comment

https://gerrit.wikimedia.org/r/134109
Comment 5 Andre Klapper 2014-09-01 12:40:42 UTC
Patch in comment 4 was merged - assuming this bug is FIXED.
If that is not the case: Please reopen and elaborate what is left to do here to get this report fixed.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links