Last modified: 2014-06-27 18:17:35 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65908, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 63908 - File usage links should display namespace prefix
File usage links should display namespace prefix
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
MultimediaViewer (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-04-14 18:39 UTC by Keegan Peterzell
Modified: 2014-06-27 18:17 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Keegan Peterzell 2014-04-14 18:39:27 UTC
Multimedia Viewer currently does not display namespace prefixes. For example, if I use File:Foo on page "User talk:Keegan", it should show an appropriate link to that namespace. Instead MMV displays the file usage link as "Keegan," making it appear as though it is in the main page space. This is undesired behavior.
Comment 1 TeleComNasSprVen 2014-04-27 09:11:08 UTC
I think the problem is in \MultimediaViewer\resources\mmv\ui\mmv.ui.fileUsage.js in line 138, item.page.getMainText() but I don't know how to fix. Also, the problem is for both local and global file links.
Comment 2 Tisza Gergő 2014-04-28 20:45:45 UTC
We probably want to use getPrefixedText() instead.
Comment 3 se4598 2014-05-05 18:22:29 UTC
(In reply to TeleComNasSprVen from comment #1)
> Also, the problem is for both local and global file links.

I don't think that's currently the case, at least for at my examples.
For example at https://fr.wikipedia.org/wiki/Portail:Animaux_de_compagnie#mediaviewer/Fichier:Golden_retriever_welpe_meer.jpg
see "On other sites": "Benutzer:Vorderstrasse" (prefixed with user namespace)

see Bug 64910 with a namespace prefix too much in the linked url though.
So was the api call changed there so the namespace is now also returned as part of title?
Comment 4 Gerrit Notification Bot 2014-06-12 17:39:58 UTC
Change 138999 had a related patch set uploaded by Gergő Tisza:
Fix URL handling for global usage list

https://gerrit.wikimedia.org/r/138999
Comment 5 Gerrit Notification Bot 2014-06-27 17:41:19 UTC
Change 138999 merged by jenkins-bot:
Fix URL handling for global usage list

https://gerrit.wikimedia.org/r/138999

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links