Last modified: 2014-04-23 08:28:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65926, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 63926 - PHP shims for JSON i18n files are unnecessarily loaded
PHP shims for JSON i18n files are unnecessarily loaded
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Internationalization (Other open bugs)
1.23.0
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-04-15 00:33 UTC by Kevin Israel (PleaseStand)
Modified: 2014-04-23 08:28 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---
siebrand: Backport_to_Stable+


Attachments

Description Kevin Israel (PleaseStand) 2014-04-15 00:33:18 UTC
From Adrian Lang's email to wikitech-l <http://www.gossamer-threads.com/lists/wiki/wikitech/452196>:

> * The shims for $wgExtensionMessagesFiles as generated by
> maintenance/generateJsonI18n.php register a handler for the hook
> LocalisationCacheRecache when included

That is true even in 1.23; LocalisationCache still includes the shims to get non-message data "For backwards compatibility [...] Variables other than $messages still need to be supported though.".

However, in practice, non-message data are contained in separate files; it is unnecessary to load the shims.
Comment 1 Gerrit Notification Bot 2014-04-15 00:35:09 UTC
Change 125925 had a related patch set uploaded by PleaseStand:
Skip loading PHP shims for JSON i18n files

https://gerrit.wikimedia.org/r/125925
Comment 2 Gerrit Notification Bot 2014-04-17 14:29:35 UTC
Change 125925 merged by jenkins-bot:
Skip loading PHP shims for JSON i18n files

https://gerrit.wikimedia.org/r/125925
Comment 3 Gerrit Notification Bot 2014-04-17 17:59:32 UTC
Change 127020 had a related patch set uploaded by Siebrand:
Skip loading PHP shims for JSON i18n files

https://gerrit.wikimedia.org/r/127020
Comment 4 Gerrit Notification Bot 2014-04-23 08:25:39 UTC
Change 127020 merged by jenkins-bot:
Skip loading PHP shims for JSON i18n files

https://gerrit.wikimedia.org/r/127020

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links