Last modified: 2014-04-23 08:29:06 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65928, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 63928 - PHP shims for JSON i18n files can register LocalisationCacheRecache handlers multiple times
PHP shims for JSON i18n files can register LocalisationCacheRecache handlers ...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Internationalization (Other open bugs)
1.23.0
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: performance
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-04-15 01:06 UTC by Kevin Israel (PleaseStand)
Modified: 2014-04-23 08:29 UTC (History)
12 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---
siebrand: Backport_to_Stable+


Attachments

Description Kevin Israel (PleaseStand) 2014-04-15 01:06:22 UTC
From Adrian Lang's email to wikitech-l <http://www.gossamer-threads.com/lists/wiki/wikitech/452196>:

> I recently investigated a performance issue with one of Wikibase's
> test cases. The test in question performed a formatting task for all
> known languages. While the first assertions ran as fast as expected,
> they rapidly got slower until finally taking seconds per assertion. I
> figured this was an actual performance bug (although hardly triggered
> in production) and started profiling.
> 
> My findings, in short:
> 
> * The shims for $wgExtensionMessagesFiles as generated by
> maintenance/generateJsonI18n.php register a handler for the hook
> LocalisationCacheRecache when included
> * For every new language loaded, all $wgExtensionMessagesFiles are
> included by LocalisationCache::recache
> * Afterwards, LocalisationCache::recache runs the hook LocalisationCacheRecache
> 
> This leads to the obvious issue that there is a growing number of
> registered handlers, which slows down the hook, which slows down the
> test.

The shims should be fixed to avoid this.
Comment 1 Gerrit Notification Bot 2014-04-15 01:07:06 UTC
Change 125706 had a related patch set uploaded by PleaseStand:
JSON i18n shim: Only register LocalisationCacheRecache handler once

https://gerrit.wikimedia.org/r/125706
Comment 2 Siebrand Mazeland 2014-04-15 10:26:02 UTC
This needs to be backported to 1.23 when merged.
Comment 3 Nemo 2014-04-15 10:29:07 UTC
Until a backport is merged, ? is used.
Comment 4 Gerrit Notification Bot 2014-04-22 10:11:36 UTC
Change 125706 merged by jenkins-bot:
JSON i18n shim: Only register LocalisationCacheRecache handler once

https://gerrit.wikimedia.org/r/125706
Comment 5 Gerrit Notification Bot 2014-04-22 10:19:11 UTC
Change 127893 had a related patch set uploaded by Siebrand:
JSON i18n shim: Only register LocalisationCacheRecache handler once

https://gerrit.wikimedia.org/r/127893
Comment 6 Gerrit Notification Bot 2014-04-23 08:23:39 UTC
Change 127893 merged by jenkins-bot:
JSON i18n shim: Only register LocalisationCacheRecache handler once

https://gerrit.wikimedia.org/r/127893

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links