Last modified: 2014-04-25 16:51:14 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65947, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 63947 - Full stop in link target causes link to not be parsed, rendered as wikitext
Full stop in link target causes link to not be parsed, rendered as wikitext
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: C. Scott Ananian
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-04-15 17:37 UTC by James Forrester
Modified: 2014-04-25 16:51 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description James Forrester 2014-04-15 17:37:11 UTC
Without the full stop it works fine:

  [//foo.org/bar#baz bang]

->

  <p><a href="//foo.org/bar#baz">bang</a></p>

… but:

  [//foo.org/bar#baz. bang]

->

  <p>[//foo.org/bar#baz. bang]</p>
Comment 1 James Forrester 2014-04-15 17:38:42 UTC
Also:

  [//foo.org/bar bang]

->

  <p><a href="//foo.org/bar">bang</a></p>

… but:

  [//foo.org/bar. bang]

->

  <p>[//foo.org/bar. bang]</p>
Comment 2 Gabriel Wicke 2014-04-15 17:45:40 UTC
The tokenizer parses the link fine, but the LinkHandler seems to think it's invalid & converts it back to text.
Comment 3 Gabriel Wicke 2014-04-15 18:03:55 UTC
The issue is that the url production in the tokenizer is used both for urllinks and the validation of general links via tokenizeURL. URL links are supposed to avoid eating trailing commas, colons and stops. In other hrefs those are fine though.

We should probably split the urllink production from the more general url production.
Comment 4 C. Scott Ananian 2014-04-15 18:31:04 UTC
A single quote produces the same issues as a period.
Comment 5 Gerrit Notification Bot 2014-04-16 22:02:27 UTC
Change 126853 had a related patch set uploaded by Cscott:
WIP: Fix a number of link-parsing and serialization issues.

https://gerrit.wikimedia.org/r/126853
Comment 6 Gerrit Notification Bot 2014-04-24 19:58:08 UTC
Change 126853 merged by jenkins-bot:
Fix a number of link-parsing and serialization issues.

https://gerrit.wikimedia.org/r/126853

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links