Last modified: 2014-04-17 21:36:16 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T65979, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 63979 - Dirty _rtselser diff
Dirty _rtselser diff
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: Gabriel Wicke
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-04-15 23:48 UTC by Gabriel Wicke
Modified: 2014-04-17 21:36 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Comment 1 Gabriel Wicke 2014-04-16 19:16:48 UTC
Seems to be related to the tables not actually being parsed as such. Minimal test case:

echo -ne '<!-- foo -->\n:{|\n|foo\n|}<!-- bar -->' | node parse
<body data-parsoid='{"dsr":[0,36,0,0]}'><!-- foo -->
<dl data-parsoid='{"dsr":[13,16,0,0]}'><dd data-parsoid='{"dsr":[13,16,1,0]}'>{|</dd></dl>
|foo
<!-- bar --></body>
Comment 2 Gabriel Wicke 2014-04-16 19:20:49 UTC
Seems to be a tokenizer issue:

echo -ne '<!-- foo -->\n:{|\n|foo\n|}<!-- bar -->' | node parse --trace peg-tokens
trace/peg-tokens              : TOKS:  [{"type":"SelfclosingTagTk","name":"meta","attribs":[{"k":"typeof","v":"mw:EmptyLine"}],"dataAttribs":{"tokens":[{"type":"COMMENT","value":" foo ","dataAttribs":{"tsr":[0,12]}},"\n"],"tsr":[0,13]}},{"type":"TagTk","name":"listItem","attribs":[],"dataAttribs":{"tsr":[13,14]},"bullets":[":"]},"{|"]
trace/peg-tokens              : TOKS:  [{"type":"NlTk","dataAttribs":{"tsr":[16,17]}},{"type":"TagTk","name":"td","attribs":[],"dataAttribs":{"tsr":[17,18]}},"foo",{"type":"SelfclosingTagTk","name":"meta","attribs":[{"k":"typeof","v":"mw:TSRMarker"},{"k":"data-tag","v":"td"}],"dataAttribs":{"tsr":[21,21]}},{"type":"NlTk","dataAttribs":{"tsr":[21,22]}},{"type":"EndTagTk","name":"table","attribs":[],"dataAttribs":{"tsr":[22,24]}}]
trace/peg-tokens              : TOKS:  [{"type":"COMMENT","value":" bar ","dataAttribs":{"tsr":[24,36]}},""]
trace/peg-tokens              : TOKS:  [{"type":"EOFTk"}]
<body data-parsoid='{"dsr":[0,36,0,0]}'><!-- foo -->
<dl data-parsoid='{"dsr":[13,16,0,0]}'><dd data-parsoid='{"dsr":[13,16,1,0]}'>{|</dd></dl>
|foo
<!-- bar --></body>
Comment 3 Gerrit Notification Bot 2014-04-16 22:12:47 UTC
Change 126854 had a related patch set uploaded by GWicke:
Bug 63979: Accept comments in eofl position

https://gerrit.wikimedia.org/r/126854
Comment 4 Gerrit Notification Bot 2014-04-16 22:47:45 UTC
Change 126854 merged by jenkins-bot:
Bug 63979: Accept comments in eofl position

https://gerrit.wikimedia.org/r/126854
Comment 5 ssastry 2014-04-17 21:36:16 UTC
Will be deployed on Monday, Apr 21st.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links