Last modified: 2014-06-10 21:04:15 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T66004, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 64004 - Hygiene: Remove disableBackToTop and enableExpandableSections from MobileFormatter.php
Hygiene: Remove disableBackToTop and enableExpandableSections from MobileFor...
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
Hygiene (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Jon
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-04-16 16:45 UTC by Jon
Modified: 2014-06-10 21:04 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Jon 2014-04-16 16:45:19 UTC 
It seems these are cruft that is no longer needed.
There is a note on "enableExpandableSections" saying:
kill with fire when there will be minimum of pre-1.1 app users remaining
Comment 1 Jon 2014-06-05 22:56:48 UTC 
I think Florian noticed this during his cleanup of the PHP documentation
Comment 2 Florian 2014-06-06 03:44:56 UTC 
Yap, see change:
https://gerrit.wikimedia.org/r/#/c/137739/
:)
Comment 3 Jon 2014-06-10 00:30:21 UTC 
Oh.. I notice protected $backToTopLink = true; is still present in MobileFormatter.php so sadly can't sign off on this bug just yet! :)

I'll submit a patch that kills that code shortly...
Comment 4 Gerrit Notification Bot 2014-06-10 00:35:04 UTC 
Change 138515 had a related patch set uploaded by Jdlrobson:
Hygiene: Kill dead variable

https://gerrit.wikimedia.org/r/138515
Comment 5 Florian 2014-06-10 07:03:23 UTC 
Oha, then we only said, that we want to remove this in one of the PS :P
Comment 6 Gerrit Notification Bot 2014-06-10 21:04:04 UTC 
Change 138515 merged by jenkins-bot:
Hygiene: Kill dead variable

https://gerrit.wikimedia.org/r/138515
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links