Last modified: 2014-04-23 13:45:59 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T66006, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 64006 - Cleanup Lucene config for MediaWiki
Cleanup Lucene config for MediaWiki
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
General/Unknown (Other open bugs)
wmf-deployment
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-04-16 17:18 UTC by Sam Reed (reedy)
Modified: 2014-04-23 13:45 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Sam Reed (reedy) 2014-04-16 17:18:49 UTC
# Better make sure the global setting is enabled
$wgUseLuceneSearch = true;
if ( $wgUseLuceneSearch ) {
	wfProfileIn( "$fname-lucene" );
	include( "$wmfConfigDir/lucene-common.php" );
	wfProfileOut( "$fname-lucene" );
}


Lucene config shouldn't be loaded for all wikis. Ideally varying on noncirrus.dblist


lucene-labs.php is also useless, pointing at Tampa IPs (and no Lucene servers setup in EQIAD for labs). Removing it, without a plain lucene.php might cause errors (I can't remember how nicely it falls back). But as per above, we shouldn't be loading this code and MWSearch etc anyway where not used etc
Comment 1 Chad H. 2014-04-16 17:47:02 UTC
(In reply to Sam Reed (reedy) from comment #0)
> # Better make sure the global setting is enabled
> $wgUseLuceneSearch = true;
> if ( $wgUseLuceneSearch ) {
> 	wfProfileIn( "$fname-lucene" );
> 	include( "$wmfConfigDir/lucene-common.php" );
> 	wfProfileOut( "$fname-lucene" );
> }
> 
> 
> Lucene config shouldn't be loaded for all wikis. Ideally varying on
> noncirrus.dblist
> 
> 

Yes it should always be loaded still. It's configured as secondary for the time being until we're 100% cut over and start decom'ing the old stuff.

> lucene-labs.php is also useless, pointing at Tampa IPs (and no Lucene
> servers setup in EQIAD for labs). Removing it, without a plain lucene.php
> might cause errors (I can't remember how nicely it falls back). But as per
> above, we shouldn't be loading this code and MWSearch etc anyway where not
> used etc

I don't disagree here.
Comment 2 Nik Everett 2014-04-16 18:12:47 UTC
+1 to Chad's stuff.  I've not done enough digging to know if we still need to load lucene for all the stuff on cirrus but everything else makes sense.
Comment 3 Gerrit Notification Bot 2014-04-16 18:26:06 UTC
Change 126804 had a related patch set uploaded by Reedy:
Only load/enable Lucene on production (not on labs)

https://gerrit.wikimedia.org/r/126804
Comment 4 Gerrit Notification Bot 2014-04-22 20:32:01 UTC
Change 126804 merged by jenkins-bot:
Only load/enable Lucene on production (not on labs)

https://gerrit.wikimedia.org/r/126804
Comment 5 se4598 2014-04-23 12:23:15 UTC
urgent: this may currently cause fatals at beta
see Bug 64283

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links