Last modified: 2014-08-19 14:40:12 UTC
Although wikistats has tests, and my email address is among the trusted email addresses in zuul-config's layout.yaml, commenting "recheck" in the third comment on change 126264 did not retrigger running tests.
Change 126838 had a related patch set uploaded by QChris: 'recheck' by whitelisted users now runs tests https://gerrit.wikimedia.org/r/126838
Posted on qa-l http://lists.wikimedia.org/pipermail/qa/2014-April/001381.html the following: TL;DR: make 'recheck' by a whitelisted user to triggers tests jobs Gerrit/Zuul have a hidden feature which is that one can comment 'recheck' on a change in Gerrit and that reenqueue the Change in the Zuul 'check' pipeline. That pipeline is meant to run linting checks which are fast whereas the actual tests are run in a 'test' pipeline. From time to time people are using 'recheck' and wondering why only the lint jobs are being run. I have upgraded Zuul today and we can slightly enhance the way changes are added to pipelines. My proposal would be to have 'recheck' to trigger the test jobs, ie the one in the 'test' pipeline. The drawback is that non whitelisted user would no more be able to use it but I dont think it provided any added value. That would save people from having to create a new patchset (via rebase, or commit summary editing) and should save a bunch of time overall. Similarly, we could add a 'regate' comment that would enqueue the change if it has been already voted CR+2. Letting anyone resubmit a change without having CR+2 rights.
Change 126838 merged by jenkins-bot: 'recheck' by whitelisted users now runs tests https://gerrit.wikimedia.org/r/126838
Merged https://gerrit.wikimedia.org/r/126838 and does not do what we wanted. Instead the much simpler https://gerrit.wikimedia.org/r/#/c/127252/ let whitelisted user fill comment 'recheck' and that will trigger the job :-] To further improve the process we could trigger the tests when a trusted user comment CR +1 on a patch sent by an untrusted user (i.e. having Verified +1).
Change 127259 had a related patch set uploaded by Hashar: Code review by whitelisted users should triggers tests https://gerrit.wikimedia.org/r/127259
Commenting "recheck" now worked as expected for analytics/wikistats. (The change in comment #5 would be great, but it's good enough for me to be able to retrigger by "recheck"-ing)
Thanks Antoine for the quick fix :-)
I proposed a patch upstream that might support the workflow described in comment #5 : https://review.openstack.org/#/c/88616/ we will see :]
Turns out the workflow described (CR+1 by trusted triggering tests) is already filled as: Bug 62429 - Zuul: run 'test' jobs on jenkins when trusted user votes +1 and only 'check' jobs was ran
