Last modified: 2014-07-08 10:28:25 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T66022, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 64022 - Production log errors: Assorted serializer errors
Production log errors: Assorted serializer errors
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
serializer (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Gabriel Wicke
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-04-16 21:18 UTC by ssastry
Modified: 2014-07-08 10:28 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description ssastry 2014-04-16 21:18:27 UTC
error in enwiki:Augmented_browsing: No handler for: <span class="addition" typeof="mw:Extension/addition" noteid="1389892508818-BfCG" data-parsoid-diff="{&quot;id&quot;:&quot;592267287&quot;,&quot;diff&quot;:[&quot;inserted&quot;]}">semi</span>

error in ptwiki:Anexo:Lista_de_episódios_de_Dragon_Ball_Kai: TR { handle: [Function], sepnls: { before: [Function] } }

error in frwiki:Les_Perdrix: In WSP.handleImage, img does not have resource or src: <span typeof="mw:Image" data-parsoid="{&quot;optList&quot;:[{&quot;ck&quot;:&quot;width&quot;,&quot;ak&quot;:&quot;20px&quot;}],&quot;dsr&quot;:[2370,2401,null,null]}" data-parsoid-diff="{&quot;id&quot;:&quot;100473416&quot;,&quot;diff&quot;:[&quot;subtree-changed&quot;]}"><span data-parsoid-diff="{&quot;id&quot;:&quot;100473416&quot;,&quot;diff&quot;:[&quot;inserted&quot;]}"><img></span></span>

error in enwiki:2013–14_Thai_political_crisis: TABLE { handle: [Function], sepnls: { before: [Function] } }

error in frwiki:Hernán_Cortés: In WSP.handleImage, node does not have any img elements: <figure data-parsoid="{&quot;optList&quot;:[{&quot;ck&quot;:&quot;thumbnail&quot;,&quot;ak&quot;:&quot;thumb&quot;},{&quot;ck&quot;:&quot;caption&quot;,&quot;ak&quot;:&quot;Le château de Medellín.&quot;}],&quot;dsr&quot;:[2723,2783,2,2]}" class="mw-default-size" typeof="mw:Image/Thumb" data-parsoid-diff="{&quot;id&quot;:&quot;102684343&quot;,&quot;diff&quot;:[&quot;deleted-child&quot;,&quot;subtree-changed&quot;]}"><a data-parsoid="{&quot;a&quot;:{&quot;href&quot;:&quot;./Fichier:Medellincastillo.jpg&quot;},&quot;dsr&quot;:[2725,null,null,null]}" href="./Fichier:Medellincastillo.jpg" data-parsoid-diff="{&quot;id&quot;:&quot;102684343&quot;,&quot;diff&quot;:[&quot;deleted-child&quot;,&quot;subtree-changed&quot;]}"></a><meta typeof="mw:DiffMarker"></figure>
Comment 1 Arlo Breault 2014-04-16 22:46:01 UTC
From #63790,

error in frwiki:Dialogue_du_chapon_et_de_la_poularde: In WSP.handleImage, node does not have any img elements: <span typeof="mw:Image" data-parsoid="{&quot;optList&quot;:[{&quot;ck&quot;:&quo
t;width&quot;,&quot;ak&quot;:&quot;20px&quot;}],&quot;dsr&quot;:[2210,2241,null,null]}"></span>
Stack:
  WikitextSerializer.figureHandler (/usr/lib/parsoid/src/lib/wts.LinkHandler.js:543:12)
  Object.TagHandlers.span.handle (/usr/lib/parsoid/src/lib/wts.TagHandlers.js:801:23)
Comment 2 ssastry 2014-04-18 15:22:49 UTC
(In reply to Arlo Breault from comment #1)
> From #63790,
> 
> error in frwiki:Dialogue_du_chapon_et_de_la_poularde: In WSP.handleImage,
> node does not have any img elements: <span typeof="mw:Image"
> data-parsoid="{&quot;optList&quot;:[{&quot;ck&quot;:&quo
> t;width&quot;,&quot;ak&quot;:&quot;20px&quot;}],&quot;dsr&quot;:[2210,2241,
> null,null]}"></span>
> Stack:
>   WikitextSerializer.figureHandler
> (/usr/lib/parsoid/src/lib/wts.LinkHandler.js:543:12)
>   Object.TagHandlers.span.handle
> (/usr/lib/parsoid/src/lib/wts.TagHandlers.js:801:23)

Can be reproduced with this snippet: "[http://google.com [[Image:Foo.jpg|20px]]]" -- this is bad nesting (link within a link). We have code in DOM fragment unpacking for dealing with a-nested-in-a scenario and fixing things up which may not be handling images correctly. You can see a "misnested:true" flag in the parse output, but it is leaving behind a Image span wrapper in the extlink a-tag which is what trips up the serializer (and would trip up VE as well, I imagine).
Comment 3 ssastry 2014-05-01 20:53:00 UTC
New failures after today's deploy with oldids so we can better debug these.

[fatal][commonswiki:Commons:Village_pump/Archive/2012/04][oldid:89940097] Cannot read property 'nodeName' of null
[fatal][enwiki:User:The_Obento_Musubi/Sandbox/Archive_3][oldid:605399257] Cannot read property 'nodeName' of null
[fatal][enwikivoyage:Wikivoyage:List_of_template_transclusions][oldid:2577267] Cannot read property 'tsr' of undefined
[fatal][fawiki:الگو:Cmbox][oldid:8301284] Cannot read property 'nodeName' of null
[fatal][fawiki:حادثه_۱۳۶۶_حج][oldid:12538010] Cannot read property 'tsr' of undefined
[fatal][frwiki:Discussion:Batna][oldid:85943356] Cannot read property 'nodeName' of null
[fatal][frwiki:Discussion:Vague_belge_d'ovnis][oldid:103426136] Cannot read property 'nodeName' of null
[fatal][itwiki:Discussioni_progetto:Aviazione/Archivio22][oldid:49763882] Cannot read property 'nodeName' of null
[fatal][itwiki:Discussioni_progetto:Aviazione/Template/Archivio2][oldid:61182245] Cannot read property 'nodeName' of null
[fatal][itwiki:Discussioni_utente:Helios/Archivio14][oldid:52327760] Cannot read property 'tsr' of undefined
[fatal][plwiki:Pomoc:Przewodnicy][oldid:39365513] Cannot read property 'tsr' of undefined
Comment 4 ssastry 2014-05-01 23:43:32 UTC
The nodeName null errors are actually template encapsulation crashers. Reduced test case to reproduce:
----
<table>
{{#if:|
<td>foo</td>
}}
</table>
----
Comment 5 Arlo Breault 2014-07-08 10:28:25 UTC
We don't seem to be producing any of these errors anymore.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links