Last modified: 2014-04-17 14:33:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T66024, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 64024 - Event not validating, unknown cause


Summary:	Event not validating, unknown cause

Status:	RESOLVED INVALID

Product:	Analytics
Classification:	Unclassified
Component:	EventLogging (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	High normal
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-04-16 21:25 UTC by Yuvi Panda
Modified:	2014-04-17 14:33 UTC (History)
CC List:	8 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Yuvi Panda 2014-04-16 21:25:11 UTC

Steps to repro:

1. hit https://bits.wikimedia.org/event.gif?%7B%22schema%22%3A%22MobileWikiAppEdit%22%2C%22revision%22%3A8188113%2C%22event%22%3A%7B%22action%22%3A%22start%22%2C%22userName%22%3A%22yuvitest44%22%2C%22editSessionToken%22%3A%2277078656-8520-4c5d-832a-7b37b4ba7cf8%22%7D%7D
2. Note that it reaches varnish
3. Note that it doesn't reach db

When URL Decoded, the payload comes to {"schema":"MobileWikiAppEdit","revision":8188113,"event":{"action":"start","userName":"yuvitest44","editSessionToken":"77078656-8520-4c5d-832a-7b37b4ba7cf8"}}

which to me looks like it should validate against both the EventCapsule schema and the MobileWikiAppEdit schema.

Comment 1 nuria 2014-04-17 14:18:38 UTC

In this example the capsule is missing, who is adding the capsule in your case?

Comment 2 Yuvi Panda 2014-04-17 14:25:04 UTC

I'm adding revision and schema, and I guess the EventLogging servers should add the UA?

Comment 3 Yuvi Panda 2014-04-17 14:26:42 UTC

When I checked the logs coming through from varnishcsa, they did have a UA

Comment 4 Yuvi Panda 2014-04-17 14:33:03 UTC

Cause was between keyboard and chair. I wasn't setting 'wiki' in the capsule, causing events to be discarded. Fixed.

Thanks to Nuria for spotting!

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links