Last modified: 2014-04-18 14:50:59 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T66069, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 64069 - PHP Notice on Special:Version with Scribunto enabled


Summary:	PHP Notice on Special:Version with Scribunto enabled

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	Scribunto (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Low minor (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-04-17 18:26 UTC by Sam Reed (reedy)
Modified:	2014-04-18 14:50 UTC (History)
CC List:	3 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Sam Reed (reedy) 2014-04-17 18:26:15 UTC

Undefined offset: 0 in core/includes/specials/SpecialVersion.php on line 968


Only appears with Scribunto enabled. Disabling scribunto makes it go away

Comment 1 Sam Reed (reedy) 2014-04-17 18:42:20 UTC

array(1) {
  ["scribunto"]=>
  string(28) "ScribuntoHooks::reportLimits"
}


string(77) "SpecialVersion::execute/SpecialVersion::getWgHooks/SpecialVersion::listToText"

Comment 2 Sam Reed (reedy) 2014-04-17 18:48:24 UTC

$wgHooks['ParserLimitReport']['scribunto'] = 'ScribuntoHooks::reportLimits';

Comment 3 Gerrit Notification Bot 2014-04-17 18:49:01 UTC

Change 127031 had a related patch set uploaded by Reedy:
Fix PHP Notice on Special:Version with Scribunto enabled

https://gerrit.wikimedia.org/r/127031

Comment 4 Gerrit Notification Bot 2014-04-17 19:03:30 UTC

Change 127115 had a related patch set uploaded by Reedy:
Simplify SpecialVersion:listToText()

https://gerrit.wikimedia.org/r/127115

Comment 5 Sam Reed (reedy) 2014-04-17 21:08:27 UTC

Needs $wgSpecialVersionShowHooks to be set to true to replicate

Comment 6 Gerrit Notification Bot 2014-04-18 14:45:12 UTC

Change 127031 abandoned by Anomie:
Fix PHP Notice on Special:Version with Scribunto enabled

Reason:
Per Reedy's comment that this should be abandoned if this is done purposefully.

https://gerrit.wikimedia.org/r/127031

Comment 7 Gerrit Notification Bot 2014-04-18 14:48:12 UTC

Change 127115 merged by jenkins-bot:
Simplify SpecialVersion:listToText()

https://gerrit.wikimedia.org/r/127115

Comment 8 Brad Jorsch 2014-04-18 14:50:59 UTC

Confirmed that Gerrit change #127115 is sufficient to fix the issue.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links