Last modified: 2014-04-24 19:06:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T66082, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 64082 - Flow: logic of edit_existing browser test is broken
Flow: logic of edit_existing browser test is broken
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
master
All All
: High normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-04-18 01:08 UTC by spage
Modified: 2014-04-24 19:06 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description spage 2014-04-18 01:08:33 UTC
The edit_existing browser test is failing on beta2 for chrome; I've noticed other test runs failing on it.

With Chrome,
    When I click Edit post
targets class .flow-edit-post-link with topic_index 1, i.e., the second editable post.  But this is not necessarily the second topic, it could be anything. (The variable name is wrong, it should be editable_post_index 1; and there might not be anything editable on the board.)

The test succeeds in adding text to this post, successfully.
Then to confirm the saved text works,
      And the saved post should contain Post edited
looks for class .flow-post-content with topic_index 1. But that's just the second post on the page, it could be anything -- an anonymous post, some other random thing.

It seems pure coincidence that this works at all!

The short-term fix is to target the same editable_post_index when checking. The Nth editable post remains editable after you edit it.

Longer term, all the Flow content tests need to zero in on a particular topic and post, *remember what it is*, then interact within that and check *within that topic*.
Comment 1 Chris McMahon 2014-04-24 19:06:23 UTC
Not coincidence at all, I worked hard on this. :-)

The reason this test fails for Chrome is https://bugzilla.wikimedia.org/show_bug.cgi?id=64378

I'll take it out of the Chrome build for now.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links