Last modified: 2014-06-13 09:44:50 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T66086, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 64086 - Notice: Undefined variable: file_extension_length
Notice: Undefined variable: file_extension_length
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
GWToolset (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-04-18 08:33 UTC by dan
Modified: 2014-06-13 09:44 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
sample dataset (9.34 KB, text/xml)
2014-04-18 08:33 UTC, dan
Details

Description dan 2014-04-18 08:33:36 UTC
Created attachment 15135 [details]
sample dataset

the extension does not set the variable to an initial value, so that when the code reaches line 412 it has not been set. also, the test on line 408 needs to test the strlen() of the $result, which it does not.

in order to see the PHP Notice, you need to have GWToolset installed in an 
environment that has error_reporting set to E_STRICT|E_ALL.

once logged in and at Step 1: Metadata detection

step 1
------
1. nothing to add
2. select Artwork
3. nothing to add
4. nothing to add
5. choose the attached sample dataset.

step 2
------
1. map the following fields
   title identifier       =>  dc:identifier
   url to the media file  =>  europeana:object
2. press the "Preview batch" button

step 3
------
1. click on one of the resulting files
2. notice the PHP Notice: Undefined variable: file_extension_length in 
   /extensions/GWToolset/includes/Models/MediawikiTemplate.php on line 412
Comment 1 Gerrit Notification Bot 2014-04-18 08:37:28 UTC
Change 127211 had a related patch set uploaded by Dan-nl:
fix MediawikiTemplate::getTitle() method

https://gerrit.wikimedia.org/r/127211
Comment 2 Gerrit Notification Bot 2014-04-22 23:41:10 UTC
Change 127211 merged by jenkins-bot:
fix MediawikiTemplate::getTitle() method

https://gerrit.wikimedia.org/r/127211

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links