Last modified: 2014-04-21 20:11:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T66102, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 64102 - Flow: action=history triggers parsoid parsing of wikitext posts
Flow: action=history triggers parsoid parsing of wikitext posts
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
master
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-04-18 19:59 UTC by spage
Modified: 2014-04-21 20:11 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description spage 2014-04-18 19:59:00 UTC
I manually start parsoid with `node api/server.js`. On my local wiki, ?action=history produces lots of "starting/stopping parsing of localhost:SomePage" messages, but only for posts that were stored as wikitext.

The stack trace in the call to parsoid() is below.  Flow\Formatter\BoardHistory->formatHtml() calls Flow\Formatter\RevisionFormatter->formatApi() which retrieves the revision content as HTML, thus triggering wikitext conversion to HTML.  But BoardHistory never uses the 'content' element of the array, nor I think do other formatters, maybe we can drop it?  (Some formatters invoke processParam( 'summary' ) which explicitly gets the content and has a a comment about the conversion.)

#0  Flow\Parsoid\Utils::parsoid() called at [/home/spage/projects/core/extensions/Flow/includes/Parsoid/Utils.php:30] 
#1  Flow\Parsoid\Utils::convert() called at [/home/spage/projects/core/extensions/Flow/includes/Model/AbstractRevision.php:424] 
#2  Flow\Model\AbstractRevision->getContent() called at [/home/spage/projects/core/extensions/Flow/includes/Templating.php:451] 
#3  Flow\Templating->getContent() called at [/home/spage/projects/core/extensions/Flow/includes/Formatter/RevisionFormatter.php:86] 
#4  Flow\Formatter\RevisionFormatter->formatApi() called at [/home/spage/projects/core/extensions/Flow/includes/Formatter/BoardHistory.php:34] 
#5  Flow\Formatter\BoardHistory->formatHtml() called at [/home/spage/projects/core/extensions/Flow/includes/Formatter/BoardHistory.php:26] 
#6  Flow\Formatter\BoardHistory->format() called at [/home/spage/projects/core/extensions/Flow/includes/Block/BoardHistory.php:59] 
#7  Flow\Block\BoardHistoryBlock->render() called at [/home/spage/projects/core/extensions/Flow/includes/Block/Block.php:151] 
#8  Flow\Block\AbstractBlock->onRender() called at [/home/spage/projects/core/extensions/Flow/includes/View.php:80] 
#9  Flow\View->show() called at [/home/spage/projects/core/extensions/Flow/Hooks.php:290] 
#10 FlowHooks::onPerformAction() 
#11 call_user_func_array() called at [/home/spage/projects/core/includes/Hooks.php:206] 
#12 Hooks::run() called at [/home/spage/projects/core/includes/GlobalFunctions.php:4011] 
#13 wfRunHooks() called at [/home/spage/projects/core/includes/Wiki.php:410] 
#14 MediaWiki->performAction() called at [/home/spage/projects/core/includes/Wiki.php:292] 
#15 MediaWiki->performRequest() called at [/home/spage/projects/core/includes/Wiki.php:588] 
#16 MediaWiki->main() called at [/home/spage/projects/core/includes/Wiki.php:447] 
#17 MediaWiki->run() called at [/home/spage/projects/core/index.php:49]

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links