Last modified: 2014-06-09 19:18:06 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T66104, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 64104 - VisualEditor: Re-used references don't always match
VisualEditor: Re-used references don't always match
Status: RESOLVED WONTFIX
Product: VisualEditor
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Unprioritized minor
: ---
Assigned To: Editing team bugs – take if you're interested!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-04-18 21:21 UTC by WhatamIdoing
Modified: 2014-06-09 19:18 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description WhatamIdoing 2014-04-18 21:21:11 UTC
Intention:
Remove a copyright violation

Steps to Reproduce:
I removed the first instance of a ref tag.  See https://en.wikipedia.org/w/index.php?title=Male_rape&diff=604793477&oldid=604792987


Actual Results:  
The re-used ref was "moved", but that had the effect of changing it, because the next instance of the same named ref had a different description.


Reproducible: Didn't try

I don't know how to solve this.  The wikitext shouldn't have been written that way in the first place.
Comment 1 James Forrester 2014-06-09 16:40:59 UTC
I'm pretty sure this is a WONTFIX; if the wikitext is in such a broken state that it defines a reference twice, there's nothing sane that VisualEditor can really do.
Comment 2 WhatamIdoing 2014-06-09 19:16:02 UTC
There's no way for VisualEditor to know which is the "right" ref when two refs have the same name but different content.  I've seen this occasionally, and the "mismatched" refs sometimes have functionally the same content (e.g., one with a typo or abbreviation not present in the other).

We could pop up an message about the error in the wikitext (which is probably something that should be done by MediaWiki, not VisualEditor).  In VisualEditor, we could rename the refs to force them to be separated.   Or we could do nothing, and maintain bug-for-bug compatibility with Cite.php's lack of internal checking.
Comment 3 James Forrester 2014-06-09 19:18:06 UTC
(In reply to WhatamIdoing from comment #2)
> There's no way for VisualEditor to know which is the "right" ref when two
> refs have the same name but different content.  I've seen this occasionally,
> and the "mismatched" refs sometimes have functionally the same content
> (e.g., one with a typo or abbreviation not present in the other).
> 
> We could pop up an message about the error in the wikitext (which is
> probably something that should be done by MediaWiki, not VisualEditor).  In
> VisualEditor, we could rename the refs to force them to be separated.   Or
> we could do nothing, and maintain bug-for-bug compatibility with Cite.php's
> lack of internal checking.

See bug 66233 for warning/stopping the user in Cite.php for this and other issues.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links