Last modified: 2014-04-22 13:34:50 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T66107, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 64107 - two-dot "ellipsis" appears in the end of "postmerge build failed.."
two-dot "ellipsis" appears in the end of "postmerge build failed.."
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Continuous integration (Other open bugs)
wmf-deployment
All All
: Low enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-04-18 21:35 UTC by Amir E. Aharoni
Modified: 2014-04-22 13:34 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Amir E. Aharoni 2014-04-18 21:35:05 UTC
Recently some commits have a postmerge build step. The automatic code review message is "postmerge build failed..", for example in the end of
https://gerrit.wikimedia.org/r/#/c/127367/ .

This is most likely wrong. If it's supposed to be an ellipsis, then it's supposed to have three dots. If it's just the end of a sentence, then it's supposed to have just one dot (full stop).

Of course it's possible that it's supposed to be two dots for some other reason.
Comment 1 Antoine "hashar" Musso (WMF) 2014-04-18 21:45:57 UTC
Simply edit the string in integration/zuul-config.git in layout.yaml file:

https://git.wikimedia.org/blob/integration%2Fzuul-config.git/8ba1a62f0b7e33f4a059451f0b24551ca87df675/layout.yaml#L261

There are two dots there :-]

If you can come up with better messages, I am all for it!
Comment 2 Amir E. Aharoni 2014-04-18 21:56:54 UTC
Thanks for the quick response. Commit: https://gerrit.wikimedia.org/r/#/c/127376/

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links