Last modified: 2014-05-21 20:13:06 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T66109, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 64109 - [Trebuchet] did not correctly recreate a submodule upon deletion
[Trebuchet] did not correctly recreate a submodule upon deletion
Status: NEW
Product: Wikimedia
Classification: Unclassified
Deployment systems (Other open bugs)
wmf-deployment
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-04-18 21:55 UTC by Ori Livneh
Modified: 2014-05-21 20:13 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ori Livneh 2014-04-18 21:55:00 UTC
/srv/deployment/... dirs on the deployment server should be group-writable, to allow non-root deployers to pull new changes. Matt Walker reports that the submodule directories for the ocg repository were not.
Comment 1 Matt Walker 2014-04-18 21:58:11 UTC
They were originally actually :p What happened was

1) I changed the repo that the grain was deploying from
2) I noticed that the repo change was not reflected in the /srv/deployment/ocg/ocg folder on tin
3) I deleted /srv/deployment/ocg/ocg
4) Puppet recreated /srv/deployment/ocg/ocg

At the end of that process everything in ocg/ocg was rw to wikidev, but the folder itself was not.

I had ori give wikidev rw on ocg/ocg as an interim step, but presumably puppet should be able to recreate with proper permissions.
Comment 2 Matt Walker 2014-04-18 22:23:17 UTC
When I ran `git deploy sync --force` it also complained that the setting deploy.repo-name did not exist. I recreated that by hand and all was good.
Comment 3 Bryan Davis 2014-05-21 20:13:06 UTC
We just saw the same behavior on deployment-bastion for the same repository:
* /srv/deployment/ocg/ocg had 0755 permissions instead of 0775
* /srv/deployment/ocg/ocg/.git/config was missing the [deploy] section
* Submodules were present in the checkout but not in .git/config

I fixed this by:
* sudo chmod g+w /srv/deployment/ocg/ocg
* git submodule update --init --recursive
* Added [deploy] section to .git/config:
** repo-name = ocg/ocg
** deploy.checkout-submodules = true

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links