Last modified: 2014-06-02 11:51:22 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T66163, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 64163 - frame:preprocess and expandTemplate shouldn't count toward execution time
frame:preprocess and expandTemplate shouldn't count toward execution time
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
Scribunto (Other open bugs)
unspecified
All All
: Low normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-04-20 21:12 UTC by Jackmcbarn
Modified: 2014-06-02 11:51 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jackmcbarn 2014-04-20 21:12:49 UTC
Some modules currently transclude a template whose name depends on parameters received, such as Module:Documentation on enwiki. In these types of cases, the module has to call frame:expandTemplate, but this counts towards Lua's time limit. The change at https://en.wikipedia.org/w/index.php?title=Template:Documentation&diff=605027466&oldid=593265833 was made to work around this behavior. Since there's no time limit on preprocessing text or expanding templates from wikitext, I don't see why there needs to be one from Lua.
Comment 1 Brad Jorsch 2014-04-21 01:35:33 UTC
(In reply to Jackmcbarn from comment #0)
> Since there's no time limit on preprocessing text or expanding
> templates from wikitext, I don't see why there needs to be one from Lua.

That's not exactly a good argument, since the Scribunto time limit is to avoid the situation we have with wikitext where pages will take minutes to parse.
Comment 2 Jackmcbarn 2014-04-21 01:51:24 UTC
It's not Lua's fault that it takes a long time to expand wikitext. This is intended to facilitate converting things a little at a time, the way the arguments change was. Is the Template:Documentation change really what we want to see everywhere?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links