Last modified: 2014-08-30 15:17:18 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T66176, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 64176 - Patrol link is misplaced when content contains uncleared floating elements
Patrol link is misplaced when content contains uncleared floating elements
Status: REOPENED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
1.23.0
All All
: Normal minor (vote)
: ---
Assigned To: Fomafix
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-04-21 09:34 UTC by Fomafix
Modified: 2014-08-30 15:17 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot of https://www.wikidata.org/w/index.php?title=Q16244272&curid=17868521&diff=121515001&oldid=121231169&uselang=en (174.73 KB, image/png)
2014-04-21 09:34 UTC, Fomafix
Details
Screenshot of https://www.wikidata.org/w/index.php?title=Q16244272&curid=17868521&diff=121515001&oldid=121231169&uselang=en (155.52 KB, image/png)
2014-08-19 14:20 UTC, Fomafix
Details

Description Fomafix 2014-04-21 09:34:03 UTC
Created attachment 15143 [details]
Screenshot of https://www.wikidata.org/w/index.php?title=Q16244272&curid=17868521&diff=121515001&oldid=121231169&uselang=en

The patrol link is misplaced. See screenshot.

Possible solutions are:

.patrollink {
    white-space: nowrap;
}

or

.patrollink {
    clear: left;
    display: block;
}

or an other position in the DOM tree.
Comment 1 Gerrit Notification Bot 2014-04-21 12:05:18 UTC
Change 127624 had a related patch set uploaded by Gerrit Patch Uploader:
Add clear:both to patrollink

https://gerrit.wikimedia.org/r/127624
Comment 2 Fomafix 2014-04-21 13:37:06 UTC
Concerns patrol link on all diff pages when content contains uncleared floating elements.
Comment 3 Gerrit Notification Bot 2014-04-22 18:48:43 UTC
Change 128966 had a related patch set uploaded by Gerrit Patch Uploader:
Enclose parser output into a div container

https://gerrit.wikimedia.org/r/128966
Comment 4 Krinkle 2014-04-22 19:10:42 UTC
The problem is with the location the patrol link is output in. It's just dumped in a very bad place (both technically awkward and in terms of user experience).
Comment 5 Lydia Pintscher 2014-08-19 10:33:47 UTC
This seems to be fixed now.
Comment 6 Gerrit Notification Bot 2014-08-19 10:48:06 UTC
Change 128966 abandoned by Bartosz Dziewoński:
Enclose parser output into a div container

https://gerrit.wikimedia.org/r/128966
Comment 7 Gerrit Notification Bot 2014-08-19 10:48:12 UTC
Change 127624 abandoned by Bartosz Dziewoński:
Clear floating elements from content

https://gerrit.wikimedia.org/r/127624
Comment 8 Fomafix 2014-08-19 14:20:32 UTC
Created attachment 16235 [details]
Screenshot of https://www.wikidata.org/w/index.php?title=Q16244272&curid=17868521&diff=121515001&oldid=121231169&uselang=en

The problem still exits. See actual screenshot.
Comment 9 Lydia Pintscher 2014-08-19 15:43:17 UTC
Hmmm I just checked an unpratrolled edit in Firefox and Chromium and it looks fine. What browser are you using? Is a gadget maybe responsible? Can anyone else reproduce it?
Comment 10 Fomafix 2014-08-19 16:47:01 UTC
(In reply to Lydia Pintscher from comment #9)
> What browser are you using?

I generated the screenshot with Firefox. Other browsers have the same result.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links