Last modified: 2014-04-24 01:10:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T66199, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 64199 - VisualEditor: [Regression] Only most recently added parameter gets trash can icon in citation dialog
VisualEditor: [Regression] Only most recently added parameter gets trash can ...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2014-04-24
Assigned To: Trevor Parscal
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-04-21 19:21 UTC by Rummana Yasmeen
Modified: 2014-04-24 01:10 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Before applying the changes (43.27 KB, image/png)
2014-04-21 19:21 UTC, Rummana Yasmeen
Details
After applying changes (40.12 KB, image/png)
2014-04-21 19:25 UTC, Rummana Yasmeen
Details

Description Rummana Yasmeen 2014-04-21 19:21:10 UTC
Created attachment 15150 [details]
Before applying the changes

Steps to reproduce:

1.Open a page with VE
2.Go to Cite>Website/Book/Newspaper/Journal
3.Add some optional parameters from the parameter list 
4.Also add the parameter URL as an optional parameter
5.Apply changes

Observed Result:
Observe that, before applying changes the parameter URL does not have a trash icon beside but the other optional parameter does.But, after applying the changes , the trash icon does appear for the parameter URL but not for the other one.

Test Environment: http://en.wikipedia.beta.wmflabs.org/
Browser:: Chrome Version 26.0.1410.65
OS: MAC OS X 10. 8. 5 
Page:http://en.wikipedia.beta.wmflabs.org/wiki/21staprilchrome?veaction=edit
Comment 1 Rummana Yasmeen 2014-04-21 19:25:28 UTC
Created attachment 15151 [details]
After applying changes
Comment 2 Roan Kattouw 2014-04-21 20:32:58 UTC
It seems that the logic here is that:
* When creating a new citation, none of the default parameters can be removed
* When inspecting an existing citation, only the first (topmost) parameter can be removed
* After adding a new parameter, only that parameter can be removed
Comment 3 Roan Kattouw 2014-04-21 20:35:44 UTC
This is only broken in the citation inspector, it works fine in the template inspector.
Comment 4 Gerrit Notification Bot 2014-04-24 00:36:55 UTC
Change 129344 had a related patch set uploaded by Trevor Parscal:
Make citation dialog display like transclusion dialog in single mode

https://gerrit.wikimedia.org/r/129344
Comment 5 Gerrit Notification Bot 2014-04-24 01:09:57 UTC
Change 129344 merged by jenkins-bot:
Make citation dialog display like transclusion dialog in single mode

https://gerrit.wikimedia.org/r/129344

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links