Last modified: 2014-04-29 17:18:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T66286, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 64286 - $2 in message "requestaccount-email-body-admin" interpreted incorrectly
$2 in message "requestaccount-email-body-admin" interpreted incorrectly
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
ConfirmAccount (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: i18n
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-04-23 14:09 UTC by [[kgh]]
Modified: 2014-04-29 17:18 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description [[kgh]] 2014-04-23 14:09:58 UTC
The closing quote of the message merges into the URL inserted with variable $2 thus breaking the link, e.g.

"NewUser" has requested an account and is waiting for confirmation.
The email address has been confirmed. You can confirm the request here "<http://www.example.org/Special:ConfirmAccounts">.

I have inserted <> into the message for better comprehension. I guess quoting the URL should be done with <...> anyway if at all necessary.
Comment 1 [[kgh]] 2014-04-23 14:30:36 UTC
I have authored a change that I believe will fix the issue: https://gerrit.wikimedia.org/r/#/c/129178/
Comment 2 Andre Klapper 2014-04-23 17:36:20 UTC
Following http://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines for the sake of automatic notifications in Bugzilla is welcome :)
Comment 3 [[kgh]] 2014-04-23 17:42:41 UTC
Yeah, I was wondering why the bot did not act on this commit. Thought that referencing the bug within the top would do the job. Well, next time ...
Comment 4 [[kgh]] 2014-04-29 17:18:49 UTC
The patch does not work out. These nasty quotes are still being added to the link. Thus I abandoned the change.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links