Last modified: 2014-05-02 16:38:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T66302, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 64302 - Do not use comma-separator message in "7 bytes added, 8 days ago" (mobile diff)
Do not use comma-separator message in "7 bytes added, 8 days ago" (mobile diff)
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
stable (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
: design, i18n
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-04-23 17:59 UTC by Liangent
Modified: 2014-05-02 16:38 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Liangent 2014-04-23 17:59:53 UTC
I'm not sure about the correct alternative, but in some languages, comma-separator is translated as "the punctuation used to separate items in a list" which can be some other thing. See bug 44798.
Comment 1 Bingle 2014-04-23 18:00:09 UTC
Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1957
Comment 2 Max Semenik 2014-04-25 23:06:54 UTC
How serious is the impact, how many languages are affected in practice? And what is your suggestion, create a new message just for this specific case?
Comment 3 Liangent 2014-04-25 23:40:28 UTC
(In reply to Max Semenik from comment #2)
> How serious is the impact,

An incorrect punctuation is used.

> how many languages are affected in practice?

At least zh and some other zh-based languages, such as nan, cdo, gan, hak, yue or lzh (well traditionally Classical Chinese doesn't use punctuations, but zh_classicalwiki, as well as newly published books targeting ordinary readers, uses them) are affected.

> what is your suggestion, create a new message just for this specific case?

Include the punctuation in the message saying "bytes added"? (I assume "days ago" is from human timestamp)
Comment 4 Liangent 2014-04-25 23:46:49 UTC
So currently text near mobile-frontend-diffview-bytesadded / mobile-frontend-diffview-bytesremoved is lego work. This message should be written as:

    "mobile-frontend-diffview-subtitle": "$1 {{PLURAL:$1|byte|bytes}} added, $2",
    "mobile-frontend-diffview-subtitle": "$1 {{PLURAL:$1|byte|bytes}} removed, $2",

and say in doc that $1 is byte change and $2 is a human timestamp.
Comment 5 Liangent 2014-04-25 23:49:11 UTC
(In reply to Liangent from comment #4)
>     "mobile-frontend-diffview-subtitle": "$1 {{PLURAL:$1|byte|bytes}} added,
> $2",
>     "mobile-frontend-diffview-subtitle": "$1 {{PLURAL:$1|byte|bytes}}
> removed, $2",

Different keys of course.
Comment 6 Jon 2014-04-26 00:24:51 UTC
We could consider using an icon for date and use the icon as punctuation
Comment 7 Gerrit Notification Bot 2014-04-28 23:36:01 UTC
Change 130252 had a related patch set uploaded by MaxSem:
Don't misuse comma-separator message

https://gerrit.wikimedia.org/r/130252
Comment 8 Gerrit Notification Bot 2014-05-02 16:26:43 UTC
Change 130252 merged by jenkins-bot:
Don't misuse comma-separator message

https://gerrit.wikimedia.org/r/130252

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links