Last modified: 2014-05-06 12:18:55 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T66311, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 64311 - Make ChangeOpFactory depend on entity type
Make ChangeOpFactory depend on entity type
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Wikidata bugs
u=dev c=backend p=5 s=2014-04-23
:
Depends on:
Blocks: 62643
  Show dependency treegraph
 
Reported: 2014-04-23 19:41 UTC by Daniel Kinzler
Modified: 2014-05-06 12:18 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Daniel Kinzler 2014-04-23 19:41:22 UTC
There should be separate instances of ChangeOpFactory for the different entity types. Rationale:

1) what ChangeOps are defined depends on the entity type

2) what validation needs to be applied for individual ChangeOps my vary by entity type.

We'll need some service that will give us a CHangeOpFactory for a given type of entity. I hope I can find a better name than ChangeOpFactoryFactory...
Comment 2 Aude 2014-05-06 09:20:20 UTC
patch merged

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links