Last modified: 2014-09-26 22:19:39 UTC
Gerrit change #127863 was merged 48 hours ago, but the test runners are still using an older rule set, as is clear from https://integration.wikimedia.org/ci/job/mediawiki-core-phpcs-strict-HEAD/9608/console on Gerrit change #129442. Please make the CodeSniffer rule set update automatically on machines running tests.
As I stated on the Gerrit change: [..]. Whenever this is merged, one will have to update the related submodule in integration/jenkins.git (path: tools/mwcodesniffer ). Then use git-deploy on tin.eqiad.wmnet to refresh integration/jenkins.git on the production servers in /srv/deployment/integration/slave-scripts
I did do that.
Bah the job uses a different git-deploy target sorry. phpcs has for option: --standard=/srv/deployment/integration/mediawiki-tools-codesniffer/MediaWiki Should probably remove the submodule from integration/jenkins.git if it is not used :) I have refreshed the minions, that should fix the issue. git-deploy log: hashar@tin:/srv/deployment/integration/mediawiki-tools-codesniffer$ git deploy start giDeployment started. hashar@tin:/srv/deployment/integration/mediawiki-tools-codesniffer$ git pull remote: Counting objects: 11, done remote: Finding sources: 100% (4/4) remote: Getting sizes: 100% (1/1) remote: Total 4 (delta 2), reused 4 (delta 2) Unpacking objects: 100% (4/4), done. From https://gerrit.wikimedia.org/r/mediawiki/tools/codesniffer/ 0bebf0f..bf82117 master -> origin/master Updating 0bebf0f..bf82117 Fast-forward MediaWiki/ruleset.xml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) hashar@tin:/srv/deployment/integration/mediawiki-tools-codesniffer$ git deploy sync Repo: integration/mediawiki-tools-codesniffer Tag: integration/mediawiki-tools-codesniffer-sync-20140424-205855 2/2 minions completed fetch Continue? ([d]etailed/[C]oncise report,[y]es,[n]o,[r]etry): y Repo: integration/mediawiki-tools-codesniffer Tag: integration/mediawiki-tools-codesniffer-sync-20140424-205855 2/2 minions completed checkout Continue? ([d]etailed/[C]oncise report,[y]es,[n]o,[r]etry): y Deployment finished. hashar@tin:/srv/deployment/integration/mediawiki-tools-codesniffer$
And the job pass now! https://integration.wikimedia.org/ci/job/mediawiki-core-phpcs-strict-HEAD/9654/console
