Last modified: 2014-11-06 17:54:12 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T66376, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 64376 - VisualEditor: Tool to set/unset text as highlighted (<mark>)
VisualEditor: Tool to set/unset text as highlighted (<mark>)
Status: ASSIGNED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Low enhancement
: ---
Assigned To: Editing team bugs – take if you're interested!
:
Depends on:
Blocks: 47780
  Show dependency treegraph
 
Reported: 2014-04-24 18:02 UTC by WhatamIdoing
Modified: 2014-11-06 17:54 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description WhatamIdoing 2014-04-24 18:02:10 UTC
I want to use the HTML code <mark> in the newsletter and still be able to edit the draft page in VisualEditor.  Right now, adding <mark> produces nowiki tags, and opening a page with <mark> already on it prevents editing the marked text (alienated content).
Comment 1 Gerrit Notification Bot 2014-06-24 00:08:03 UTC
Change 141605 had a related patch set uploaded by Jforrester:
Split out ve.{dm,ce}.TextStyleAnnotation into parts, add other annotations

https://gerrit.wikimedia.org/r/141605
Comment 2 Gerrit Notification Bot 2014-06-30 18:56:29 UTC
Change 141605 merged by jenkins-bot:
Split out ve.{dm,ce}.TextStyleAnnotation into parts, add other annotations

https://gerrit.wikimedia.org/r/141605
Comment 3 Elitre 2014-11-05 20:58:59 UTC
Will this only allow marking the text in yellow?
Comment 4 James Forrester 2014-11-05 22:32:32 UTC
(In reply to Elitre from comment #3)
> Will this only allow marking the text in yellow?

It will mark the text with <mark>. It's up to users' browsers to decide how to show it as marked, but yes, all major browsers ape the neon-lemon-yellow highlighter colour to show this currently.
Comment 5 Elitre 2014-11-05 22:38:14 UTC
I'm unhappy. I demand the ability to pick my favorite color when highlighting.
Comment 6 James Forrester 2014-11-05 22:42:31 UTC
(In reply to Elitre from comment #5)
> I'm unhappy. I demand the ability to pick my favorite color when
> highlighting.

Talk to W3C. ;-)
Comment 7 Elitre 2014-11-05 22:49:11 UTC
No! Google Docs allows highlighting text in the color I want. Please make that happen somehow?
Comment 8 James Forrester 2014-11-05 23:53:07 UTC
(In reply to Elitre from comment #7)
> No! Google Docs allows highlighting text in the color I want. Please make
> that happen somehow?

That's not highlighting with <mark>, that's setting text background colour which is bug 73041.
Comment 9 Elitre 2014-11-06 17:54:12 UTC
I had seen that, but given that it didn't mention the word "text" and that elsewhere you were so strongly against the idea, I had to assume it was actually about the page color.
The ability to set a text background in whatever color we want (#FC0FC0, in my case) will IMHO make using <mark> unnecessary.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links