Last modified: 2014-05-16 14:17:57 UTC
After trying to edit a page, after a very long delay from reading the same page, the error "Error, edit not saved" occurs and there is no way to know or correct the problem. I assume that the edit token is stale. Steps to reproduce: 1. load a page on the mobile skin 2. wait a hour 3. edit the page 4. press the blue forward arrow button to progress and add an edit summary 5. press the green tick button to save (Steps 3-5 are done in quick succession) Expected results: The page saves. (and if the problem is the edit, it should be refetched at the point the user tries to edit, rather than when they view the article.) Actual results: Error "Error, edit not saved". The tick button is still green, inviting the user to press it again. It doesnt work. The normal back arrow button in the UI may be pressed to go back to the edit screen. After pressing the back arrow, pressing the blue forward arrow works correctly, again showing the edit summary screen but the green tick arrow doesnt work. The only option is to abandon the edit. After abandoning the edit, the user is returned to the view mode. Clicking edit again and attempting to make the same edit only puts the user into the same sequence. To make the edit, the user must refresh the view mode, press edit, etc, etc. after which it will work successfully. The edit I was attempting is https://en.wikipedia.org/w/index.php?title=License_compatibility&diff=prev&oldid=605717799
Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1967
Thanks a bunch for this report. I suspect this is due to our token handling. Will dig deeper and get to bottom of this.
(In reply to Jon from comment #2) > Thanks a bunch for this report. I suspect this is due to our token handling. > Will dig deeper and get to bottom of this. At its roots, this has nothing to do with MF, it's just usual expiry of MW edit sections. We just need to handle it gracefully.
Looking at errors from last month - bad token and edit conflicts are our greatest reason for errors: badtoken 2123 editconflict 1199 http 341 We should probably be cleverer with how we expire tokens and request new ones. That said I can't seem to find any edits for the page that John pointed out. Although it looks like there may be some issues with the corresponding event logging table. See @mobile-l:Eventlogging for editing broken
If token issues are being logged, there should be two failed mobile edits from me in ~10 minutes prior to 2014-04-25T07:24:38 UTC. The successful edit (after I refreshed the view mode of the page) was flagged as a mobile edit. https://en.wikipedia.org/w/index.php?title=License_compatibility&diff=prev&oldid=605717799
Change 130522 had a related patch set uploaded by Jdlrobson: Deal better with expired edit tokens https://gerrit.wikimedia.org/r/130522
Change 130522 merged by jenkins-bot: Deal better with expired edit tokens https://gerrit.wikimedia.org/r/130522
Marking as assigned, let's check in a week to see if this reduces edit token errors. I'll personally verify this later.
We've had no bad token errors since the 4th May [1] - that's 12 days. However the fix was merged on May 8 8:51 PM so I'm not sure if some other patch has contributed to this success. An API patch introduced in Ic1542c6e0dc566f0aa59c25d5042b16771edfc6a got merged on Fri Apr 18 21:28:11 2014 +0000 so would have made the train on 24th April and been live on all Wikimedia projects from 1st May so this could well have contributed somewhat. The last error reporting a bad token was on 13:57:26 3rd May 2014 [2]. If you look at the 12 days preceding the 3rd May there were 750 errors [3] I'm fairly confident the issue is fixed in some form though so closing. [1] select event_errorText, count(*) from MobileWebEditing_7675117 where event_action = 'error' and timestamp > 20140504000000 group by event_errorText [2] select * from MobileWebEditing_7675117 where event_action = 'error' and event_errorText = 'badtoken' order by timestamp desc limit 1 [3] select count(*) from MobileWebEditing_7675117 where event_action = 'error' and event_errorText = 'badtoken' and timestamp > 20140421000000
