Last modified: 2014-05-13 20:15:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T66434, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 64434 - VisualEditor: 0,0 initial selection in Firefox when opening a new or pre-existing references means inserting template causes fatal JS error
VisualEditor: 0,0 initial selection in Firefox when opening a new or pre-exis...
Status: VERIFIED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: High major
: VE-deploy-2014-05-01
Assigned To: Ed Sanders
:
: 64601 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-04-25 16:24 UTC by WhatamIdoing
Modified: 2014-05-13 20:15 UTC (History)
10 users (show)

See Also:
Web browser: Firefox
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description WhatamIdoing 2014-04-25 16:24:10 UTC
Steps to Reproduce:
1. Open any page in VisualEditor.

2. Go to Insert > Reference to add a reference.  Do NOT click inside the reference box.

3. Go to Insert > Template to add a template.



Actual Results:  
You can't add a template, you can't exit the dialog, you can't do anything except close the browser tab and lose all of your work.


Reproducible: Always

This cannot be reproduced in Safari.  This cannot be reproduced if you first click inside the reference box.
Comment 1 James Forrester 2014-04-30 20:29:45 UTC
Fixed in the Firefox-selection change Ed wrote.
Comment 2 Rummana Yasmeen 2014-04-30 22:20:44 UTC
Verified the fix in Betalabs
Comment 3 James Forrester 2014-05-02 21:25:28 UTC
*** Bug 64601 has been marked as a duplicate of this bug. ***
Comment 4 Rainer Rillke @commons.wikimedia 2014-05-02 21:28:48 UTC
Where is the gerrit change?
Comment 5 Roan Kattouw 2014-05-02 21:43:36 UTC
(In reply to Rainer Rillke @commons.wikimedia from comment #4)
> Where is the gerrit change?

https://gerrit.wikimedia.org/r/#/c/129806/ makes sure the tools correctly initialize as disabled if the initial selection is null

https://gerrit.wikimedia.org/r/#/c/130262/ makes sure the selection isn't 0,0 the second time you open the reference dialog
Comment 6 Rummana Yasmeen 2014-05-06 19:50:33 UTC
Verified the fix on test2
Comment 7 Rummana Yasmeen 2014-05-13 20:15:36 UTC
Verified the fix in production

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links