Last modified: 2014-06-20 16:45:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T66467, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 64467 - action=mobileview should not strip <a> tags in headings for the 'line' property
action=mobileview should not strip <a> tags in headings for the 'line' property
Status: RESOLVED INVALID
Product: MobileFrontend
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
: 66878 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-04-26 00:41 UTC by Liangent
Modified: 2014-06-20 16:45 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Liangent 2014-04-26 00:41:07 UTC

    
Comment 1 Yuvi Panda 2014-04-26 13:59:37 UTC
action=mobileview does not return HTML in its 'line' property, seems to be stripping out <a> tags
Comment 2 Bingle 2014-04-26 14:00:12 UTC
Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1972
Comment 3 Jon 2014-04-28 20:09:49 UTC
Yuvi your statement is not quite true. Line does contain HTML it just seems that links are currently getting removed.

Ideally there should be a line and lineText property - MobileFrontend already has a need for unformatted headings (table of contents as an example). The lineText property should contain the heading without any HTML markup.

See:
http://en.m.wikipedia.beta.wmflabs.org/w/api.php?action=mobileview&format=json&page=Mobile+view+headings+test&variant=en&redirect=yes&prop=id%7Csections%7Ctext%7Clastmodified%7Clastmodifiedby%7Clanguagecount%7Chasvariants%7Cprotection%7Cdisplaytitle%7Crevision&noheadings=yes&sectionprop=level%7Cline%7Canchor&sections=all


Gives:

{"mobileview":{"lastmodified":"2014-04-28T20:06:58Z","lastmodifiedby":{"name":"Jdlrobson","gender":"unknown"},"revision":91131,"id":20687,"languagecount":0,"displaytitle":"Mobile view headings test","protection":[],"sections":[{"id":0,"text":"<p></p>"},{"level":"2","line":"Test 1","anchor":"Test_1","id":1,"text":"<p>Test!!</p>"},{"level":"2","line":"<i>Test 2</i>","anchor":"Test_2","id":2,"text":"<p>Test</p>"},{"level":"2","line":"<b>Test 3</b>","anchor":"Test_3","id":3,"text":"<p>Test</p>"},{"level":"2","line":"Test 4","anchor":"Test_4","id":4,"text":"<p>Test</p>"},{"level":"2","line":"","anchor":"","id":5,"text":"<p>!</p>"}]}}
Comment 4 Yuvi Panda 2014-04-28 20:15:32 UTC
Talked with Max. The way to fix this is to not use "line": as html but to treat it as text. The Heading HTML is included with the body text but we right now suppress it with noheadings=. We should stop suppressing and oppressing and depressing them and just restyle them to look like how we want them to. They are in proper HTML.

This is a bug in the app so closing here.
Comment 5 Dan Garry 2014-06-20 16:45:20 UTC
*** Bug 66878 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links