Last modified: 2014-07-24 17:01:34 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T66495, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 64495 - Add missing globes to wikidata_family.py
Add missing globes to wikidata_family.py
Status: RESOLVED FIXED
Product: Pywikibot
Classification: Unclassified
Wikidata (Other open bugs)
core-(2.0)
All All
: Unprioritized normal
: ---
Assigned To: Pywikipedia bugs
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-04-27 08:01 UTC by Maarten Dammers
Modified: 2014-07-24 17:01 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Maarten Dammers 2014-04-27 08:01:58 UTC
These globes are supported right now:

    def globes(self, code):
        """Supported globes for Coordinate datatype"""
        return {
            'earth': 'http://www.wikidata.org/entity/Q2',
            'mars': 'http://www.wikidata.org/entity/Q111',
            'mercury': 'http://www.wikidata.org/entity/Q308',
            'mimas': 'http://www.wikidata.org/entity/Q15034',
            'moon': 'http://www.wikidata.org/entity/Q405',
            'venus': 'http://www.wikidata.org/entity/Q313',
        }

This is what I can pull from the database:

MariaDB [enwiki_p]> connect enwiki_p enwiki.labsdb;
Reading table information for completion of table and column names
You can turn off this feature to get a quicker startup with -A

Connection id:    41347153
Current database: enwiki_p

MariaDB [enwiki_p]> SELECT DISTINCT(gt_globe) FROM geo_tags LIMIT 100;
+------------+
| gt_globe   |
+------------+
| earth      |
| moon       |
| titan      |
| mars       |
| io         |
| mercury    |
| venus      |
| europa     |
| oberon     |
| phobos     |
| mimas      |
| ganymede   |
| enceladus  |
| tethys     |
| hyperion   |
| miranda    |
| umbriel    |
| callisto   |
| dione      |
| deimos     |
| phoebe     |
| ceres      |
| vesta      |
| rhea       |
| iapetus    |
| ariel      |
| titania    |
| triton     |
| pluto      |
| sun        |
| terra      |
| luna       |
| ida        |
| gaspra     |
| eros       |
| golevka    |
| borrelly   |
| jupiter    |
| metis      |
| adrastea   |
| amalthea   |
| thebe      |
| saturn     |
| pan        |
| atlas      |
| prometheus |
| pandora    |
| epimetheus |
| janus      |
| telesto    |
| calypso    |
| helene     |
| uranus     |
| cordelia   |
| ophelia    |
| bianca     |
| cressida   |
| desdemona  |
| juliet     |
| portia     |
| rosalind   |
| belinda    |
| puck       |
| neptune    |
| naiad      |
| thalassa   |
| despina    |
| galatea    |
| larissa    |
| proteus    |
| charon     |
+------------+
71 rows in set (0.76 sec)

Some statistics:

MariaDB [enwiki_p]> SELECT gt_globe, COUNT(gt_globe) FROM geo_tags WHERE NOT (gt_globe='earth' OR gt_globe='mars' OR gt_globe='mercury' OR gt_globe='mimas' OR gt_globe='
moon' OR gt_globe='venus') GROUP BY gt_globe ORDER BY COUNT(gt_globe) LIMIT 100;
+------------+-----------------+
| gt_globe   | COUNT(gt_globe) |
+------------+-----------------+
| metis      |               1 |
| charon     |               1 |
| sun        |               1 |
| belinda    |               1 |
| uranus     |               1 |
| pan        |               1 |
| eros       |               1 |
| despina    |               1 |
| desdemona  |               1 |
| janus      |               1 |
| adrastea   |               1 |
| terra      |               1 |
| puck       |               1 |
| cordelia   |               1 |
| atlas      |               1 |
| golevka    |               1 |
| galatea    |               1 |
| juliet     |               1 |
| telesto    |               1 |
| amalthea   |               1 |
| luna       |               1 |
| neptune    |               1 |
| ophelia    |               1 |
| prometheus |               1 |
| borrelly   |               1 |
| larissa    |               1 |
| portia     |               1 |
| calypso    |               1 |
| thebe      |               1 |
| ida        |               1 |
| naiad      |               1 |
| bianca     |               1 |
| pandora    |               1 |
| proteus    |               1 |
| rosalind   |               1 |
| helene     |               1 |
| saturn     |               1 |
| gaspra     |               1 |
| thalassa   |               1 |
| cressida   |               1 |
| epimetheus |               1 |
| ceres      |               2 |
| triton     |               2 |
| jupiter    |               2 |
| pluto      |               2 |
| vesta      |               3 |
| europa     |               4 |
| dione      |               5 |
| tethys     |               6 |
| deimos     |               6 |
| hyperion   |               7 |
| phoebe     |               8 |
| oberon     |              13 |
| miranda    |              14 |
| umbriel    |              17 |
| titania    |              21 |
| phobos     |              27 |
| ariel      |              28 |
| enceladus  |              49 |
| iapetus    |              72 |
| rhea       |              95 |
| callisto   |             143 |
| ganymede   |             147 |
| titan      |             150 |
| io         |             269 |
+------------+-----------------+
65 rows in set (0.58 sec)

Missing globes should be added or, if the list contains incorrect globes, fixed on the English Wikipedia.
Comment 1 Maarten Dammers 2014-04-27 08:40:57 UTC
Another, more scalable, solution would be to not hard code this list, but to keep it on Wikidata like we did with the sources.
Comment 2 Gerrit Notification Bot 2014-05-11 01:27:07 UTC
Change 132758 had a related patch set uploaded by Multichill:
Adding all the moons and (dwarf) planets which have more than one link on the English Wikipedia.

https://gerrit.wikimedia.org/r/132758
Comment 3 Gerrit Notification Bot 2014-05-11 02:00:48 UTC
Change 132762 had a related patch set uploaded by Multichill:
Don't crash when the bot hits an unknown globe

https://gerrit.wikimedia.org/r/132762
Comment 4 Gerrit Notification Bot 2014-05-11 05:47:31 UTC
Change 132758 merged by jenkins-bot:
Adding all the moons and (dwarf) planets which have more than one link on the English Wikipedia. I should probably install pep8 here.

https://gerrit.wikimedia.org/r/132758
Comment 5 Gerrit Notification Bot 2014-05-19 23:55:40 UTC
Change 132762 merged by jenkins-bot:
Don't crash when the bot hits an unknown globe

https://gerrit.wikimedia.org/r/132762
Comment 6 Gerrit Notification Bot 2014-05-25 07:10:35 UTC
Change 135296 had a related patch set uploaded by John Vandenberg:
Bug 64495: coordinate_import.py: import exception

https://gerrit.wikimedia.org/r/135296
Comment 7 Gerrit Notification Bot 2014-05-25 10:30:10 UTC
Change 135296 merged by jenkins-bot:
Bug 64495: coordinate_import.py: import exception

https://gerrit.wikimedia.org/r/135296

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links