Last modified: 2014-04-28 19:07:50 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T66512, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 64512 - [Regression] mediawiki.util broken under target=mobile (unknown dependency jquery.accessKeyLabel)
[Regression] mediawiki.util broken under target=mobile (unknown dependency jq...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
1.24rc
All All
: High blocker (vote)
: ---
Assigned To: Krinkle
: code-update-regression
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-04-27 17:36 UTC by Jon
Modified: 2014-04-28 19:07 UTC (History)
11 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Jon 2014-04-27 17:36:49 UTC 
The mobile site is currently broken on beta labs due to this rogue mobile that is currently not allowed on mobile.

JavaScript exception thrown.
Stops execution of rest of site.
Comment 1 Bingle 2014-04-27 17:40:08 UTC 
Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1973
Comment 2 Gerrit Notification Bot 2014-04-27 18:26:49 UTC 
Change 129976 had a related patch set uploaded by Krinkle:
jquery.accessKeyLabel: Enable for target=mobile

https://gerrit.wikimedia.org/r/129976
Comment 3 Gerrit Notification Bot 2014-04-27 18:35:49 UTC 
Change 129976 merged by jenkins-bot:
jquery.accessKeyLabel: Enable for target=mobile

https://gerrit.wikimedia.org/r/129976
Comment 4 Derk-Jan Hartman 2014-04-27 18:38:46 UTC 
This seems somewhat fragile.. Also I think the entire mobile target doesn't even use access keys, so we probably should decouple this in some way ?
Comment 5 Jon 2014-04-28 17:38:21 UTC 
Yeh it doesn't look like this library should be a core dependency. It suggests maybe it should/could be split up more.

TheDJ are you referring to the targets property being fragile? Alas it is but it's proved the safest way to ensure unnecessary unused code doesn't get loaded on mobile.
Comment 6 Jon 2014-04-28 19:07:50 UTC 
Opened new bug 64564
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links