Last modified: 2014-05-15 13:41:35 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T66558, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 64558 - Handle date formats like 1980x, 1980UTC, 'century' more consistently


Summary:	Handle date formats like 1980x, 1980UTC, 'century' more consistently

Status:	VERIFIED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	WikidataRepo (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	High normal (vote)
Target Milestone:	---
Assigned To:	Wikidata bugs

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	64593
	Show dependency tree / graph

Reported:	2014-04-28 17:08 UTC by Aude
Modified:	2014-05-15 13:41 UTC (History)
CC List:	4 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Aude 2014-04-28 17:08:09 UTC

entering dates like '1987x' (or replace x with any character), one gets an error:

"Precision higher thay 'DAY' is not supported yet"

Comment 1 Aude 2014-04-28 18:25:27 UTC

this error occurs in the JS time validator (javascript/lib/time/time.Time.validate.js) in DataValuesJavaScript

Comment 2 Aude 2014-04-28 18:29:57 UTC

however the problem is stuff like this

api.php?action=wbparsevalue&format=json&parser=time&values=1990x&options=%7B%7D

returns

precision: 14

if we want to support such value, then it should return max precision of a day (11)

or if we want to regard '1990x' as invalid, then do that.

Comment 3 Aude 2014-04-28 18:31:03 UTC

currently on wikidata, it is regarded as invalid.  We should probably stay consistent with that.

Comment 4 Aude 2014-04-28 18:47:10 UTC

problem is in DateTimeParser

php's DateTime happily accepts '1990x' but throws exception with '1990xx'

Comment 5 Gerrit Notification Bot 2014-04-28 19:22:59 UTC

Change 130138 had a related patch set uploaded by Aude:
Fix handling of dates in format such as 1980x

https://gerrit.wikimedia.org/r/130138

Comment 6 Gerrit Notification Bot 2014-04-28 22:41:41 UTC

Change 130236 had a related patch set uploaded by Aude:
Handle localised dates (e.g. 'century') more consistently

https://gerrit.wikimedia.org/r/130236

Comment 7 Gerrit Notification Bot 2014-04-29 15:36:57 UTC

Change 130138 merged by jenkins-bot:
Fix handling of dates in format such as 1980x or 1980UTC

https://gerrit.wikimedia.org/r/130138

Comment 8 Gerrit Notification Bot 2014-04-29 18:33:32 UTC

Change 130416 had a related patch set uploaded by Aude:
Fix handling of dates in format such as 1980x or 1980UTC

https://gerrit.wikimedia.org/r/130416

Comment 9 Gerrit Notification Bot 2014-04-29 18:47:15 UTC

Change 130416 merged by jenkins-bot:
Fix handling of dates in format such as 1980x or 1980UTC

https://gerrit.wikimedia.org/r/130416

Comment 10 Gerrit Notification Bot 2014-04-29 19:00:18 UTC

Change 130236 merged by jenkins-bot:
Handle localised dates (e.g. 'century') more consistently

https://gerrit.wikimedia.org/r/130236

Comment 11 Gerrit Notification Bot 2014-04-29 19:12:41 UTC

Change 130426 had a related patch set uploaded by Aude:
Handle localised dates (e.g. 'century') more consistently

https://gerrit.wikimedia.org/r/130426

Comment 12 Gerrit Notification Bot 2014-04-29 19:21:41 UTC

Change 130426 merged by jenkins-bot:
Handle localised dates (e.g. 'century') more consistently

https://gerrit.wikimedia.org/r/130426

Comment 13 Nemo 2014-04-30 15:15:56 UTC

Broadening scope of the summary to reflect associated patches. What's left to do?

Comment 14 Aude 2014-04-30 16:10:41 UTC

not really the same issue (this one is resolved), but bug 64545 and bug 64662 are still open.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links