Last modified: 2014-05-13 20:17:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T66646, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 64646 - VisualEditor: [Regression wmf22] "Edit source" tab for wikitext no longer selected on action=edit
VisualEditor: [Regression wmf22] "Edit source" tab for wikitext no longer sel...
Status: VERIFIED FIXED
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: Normal major
: VE-deploy-2014-05-01
Assigned To: Krinkle
: code-update-regression
: 64645 (view as bug list)
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-04-30 03:42 UTC by Erik Moeller
Modified: 2014-05-13 20:17 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Erik Moeller 2014-04-30 03:42:51 UTC 
In Vector/1.24wmf2, the "Edit source" tab is not highlighted when editing a page in source mode (no tab is highlighted).

Example:
http://www.mediawiki.org/w/index.php?title=Help:Preferences&action=edit
Comment 1 Krinkle 2014-04-30 12:53:39 UTC 
Caused by Ib2e6237483338c8072d5f7919c6459bf7418946a, which overides the 'class' attribute of the original edit tab with 'collapsed'. Thus blowing away the class "selected" that MediaWiki core puts there when on action=edit.
Comment 2 Gerrit Notification Bot 2014-04-30 13:02:05 UTC 
Change 130594 had a related patch set uploaded by Krinkle:
Preserve pre-existing css classes on edit tab link.

https://gerrit.wikimedia.org/r/130594
Comment 3 Krinkle 2014-04-30 13:03:25 UTC 
(For the record, yes, confirmed this is broken in production and on latest master).
Comment 4 Krinkle 2014-04-30 13:17:14 UTC 
*** Bug 64645 has been marked as a duplicate of this bug. ***
Comment 5 Gerrit Notification Bot 2014-04-30 16:31:31 UTC 
Change 130594 merged by jenkins-bot:
Preserve pre-existing css classes on edit tab link

https://gerrit.wikimedia.org/r/130594
Comment 6 Gerrit Notification Bot 2014-04-30 16:32:59 UTC 
Change 130622 had a related patch set uploaded by Jforrester:
Preserve pre-existing css classes on edit tab link

https://gerrit.wikimedia.org/r/130622
Comment 7 Gerrit Notification Bot 2014-04-30 23:05:33 UTC 
Change 130622 merged by Catrope:
Preserve pre-existing css classes on edit tab link

https://gerrit.wikimedia.org/r/130622
Comment 8 Rummana Yasmeen 2014-05-06 21:01:56 UTC 
Verified the fix on Production, Betalabs and Test2
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links