Last modified: 2014-10-06 09:52:16 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T66678, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 64678 - Jenkins: jenkins-bot reports spurious merge error when pushing changes to one of the gerrit config branches
Jenkins: jenkins-bot reports spurious merge error when pushing changes to one...
Status: RESOLVED DUPLICATE of bug 50389
Product: Wikimedia
Classification: Unclassified
Continuous integration (Other open bugs)
wmf-deployment
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-04-30 18:55 UTC by Tisza Gergő
Modified: 2014-10-06 09:52 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Zuul debug log showing it can't merge (2.85 KB, text/plain)
2014-04-30 21:27 UTC, Antoine "hashar" Musso (WMF)
Details

Description Tisza Gergő 2014-04-30 18:55:06 UTC
Steps to reproduce:

1. git fetch gerrit refs/meta/dashboards/custom
2. git checkout FETCH_HEAD
3. change stuff & commit
4. git push gerrit HEAD:refs/for/refs/meta/dashboards/custom

This pushes a new changeset into gerrit's special dashboard branch (refs/meta/dashboards/custom). Could be done via git-review as well, but in my experience it is not very reliable with gerrit's special config branches. (Might be setting up things wrong - I described the setup steps in detail here: http://lists.wikimedia.org/pipermail/multimedia/2014-April/000272.html )

Expected result: jenkins-bot ignores the change or marks as +2

Actual result: jenkins-bot marks as -2, claims a merge conflict (maybe tries to merge into the wrong branch?)

Example: https://gerrit.wikimedia.org/r/#/c/130643/
Comment 1 Antoine "hashar" Musso (WMF) 2014-04-30 21:21:42 UTC
Looks like a dupe of bug 50389 - Jenkins: Zuul should not run jenkins-bot on changes for refs/meta/*

I am not sure how to fix it in Zuul. Any idea welcome!
Comment 2 Antoine "hashar" Musso (WMF) 2014-04-30 21:27:28 UTC
Created attachment 15257 [details]
Zuul debug log showing it can't merge

Attached is related Zuul debug log for Gerrit change #130643

That is missing the git command being run and their output :-/
Comment 3 Tisza Gergő 2014-04-30 22:03:59 UTC
Looking at the source code [1] it seems that Zuul requests commit 46616c7365 from git and it does not exist. Which is weird - if the merge was unsuccessful, why did it return a commit id? (And if it was successful, why is it not found?)


[1] https://github.com/gitpython-developers/GitPython/blob/0.3.2-RC1/git/repo/fun.py#L79
Comment 4 Tisza Gergő 2014-04-30 22:16:03 UTC
The actual git command used seems to be "git cat-file --batch-check" with "46616c7365" as standard input. (Of course the interesting part would be the git command used to merge, and I have no clue about that.)
Comment 5 Krinkle 2014-10-06 09:52:16 UTC

*** This bug has been marked as a duplicate of bug 50389 ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links