Last modified: 2014-05-03 23:06:50 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T66684, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 64684 - App Icon is Flipped for RTL


Summary:	App Icon is Flipped for RTL

Status:	RESOLVED FIXED

Product:	Wikipedia App
Classification:	Unclassified
Component:	Generic (Other open bugs)
Version:	Android (alpha)
Hardware:	All All

Importance:	Unprioritized normal
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-04-30 22:17 UTC by Yuvi Panda
Modified:	2014-05-03 23:06 UTC (History)
CC List:	3 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Yuvi Panda 2014-04-30 22:17:00 UTC

According to Amir, it shouldn't be.

Comment 1 Gerrit Notification Bot 2014-04-30 22:29:55 UTC

Change 130757 had a related patch set uploaded by Yuvipanda:
Ensure App Icon isn't flipped for RTL languages

https://gerrit.wikimedia.org/r/130757

Comment 2 Gerrit Notification Bot 2014-04-30 22:39:08 UTC

Change 130757 merged by Dbrant:
Ensure App Icon isn't flipped for RTL languages

https://gerrit.wikimedia.org/r/130757

Comment 3 Dan Garry 2014-05-02 23:50:23 UTC

Amir, can you test that this fix works now? You'd know better than I.

Comment 4 Amir E. Aharoni 2014-05-03 08:44:28 UTC

(In reply to Dan Garry from comment #3)
> Amir, can you test that this fix works now? You'd know better than I.

I can't test it on my device now, but the icons under
/home/amire80/dev/app-wikipedia/icon-svgs/48
look good and it makes sense to make them noflip.

I also looked at other directories and found another similar icon and renamed it in https://gerrit.wikimedia.org/r/#/c/131251/ .

Comment 5 Dan Garry 2014-05-03 23:06:50 UTC

(In reply to Amir E. Aharoni from comment #4)
> I can't test it on my device now, but the icons under
> /home/amire80/dev/app-wikipedia/icon-svgs/48
> look good and it makes sense to make them noflip.
> 
> I also looked at other directories and found another similar icon and
> renamed it in https://gerrit.wikimedia.org/r/#/c/131251/ .

That patch has been merged, so I've marked this as resolved in Trello. Thanks!

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links