Last modified: 2014-09-25 06:01:33 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T66707, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 64707 - Manage z-index with LESS variables
Manage z-index with LESS variables
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
Hygiene (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Jon
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-05-01 16:41 UTC by Jon
Modified: 2014-09-25 06:01 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jon 2014-05-01 16:41:01 UTC
z-index's can be a pain and result in z-index wars where the z-index continues to get upped!

Let's create some LESS variables that define logical layers for all usages.

e.g.
@z-index-article
@z-index-overlay
@z-index-overlay-widget
Comment 1 Gerrit Notification Bot 2014-06-14 00:05:42 UTC
Change 139568 had a related patch set uploaded by Florianschmidtwelzow:
Hygiene: Manage z-index with less variables

https://gerrit.wikimedia.org/r/139568
Comment 2 Chris McMahon 2014-06-14 00:12:01 UTC
FWIW, the element <div class="transparent-shield cloaked-element"> shows up at the "top" of the z-index stack for a brief period when loading pages, and causes browser tests run locally in Chrome to fail from time to time:

Given I am logged into the mobile website                                 # features/step_definitions/common_steps.rb:12
      unknown error: Element is not clickable at point (130, 323). Other element would receive the click: <div class="transparent-shield cloaked-element"></div>
        (Session info: chrome=35.0.1916.153)
        (Driver info: chromedriver=2.10.267517,platform=Mac OS X 10.9.3 x86_64) (Selenium::WebDriver::Error::UnknownError)
      ./features/step_definitions/mainmenu_steps.rb:7:in `/^I click on "(.*?)" in the main navigation menu$/'
      ./features/step_definitions/common_steps.rb:14:in `/^I am logged into the mobile website$/'
      features/special_uploads.feature:9:in `Given I am logged into the mobile website' 

I have not figured out what function the <div class="transparent-shield cloaked-element"> serves.
Comment 3 Gerrit Notification Bot 2014-09-24 23:56:22 UTC
Change 139568 merged by jenkins-bot:
Hygiene: Manage z-index with less variables

https://gerrit.wikimedia.org/r/139568

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links