Last modified: 2014-07-24 10:25:05 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T66710, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 64710 - Embed should use localized wikitext
Embed should use localized wikitext
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
MultimediaViewer (Other open bugs)
master
All All
: Unprioritized normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
: i18n
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-05-01 20:00 UTC by Merlijn van Deen (test)
Modified: 2014-07-24 10:25 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Merlijn van Deen (test) 2014-05-01 20:00:41 UTC
Currently, the wikitext embed URL is non-localized; e.g.

https://nl.wikipedia.org/wiki/Hoofdpagina#mediaviewer/Bestand:Chicago_Board_Of_Trade_Building.jpg

shows the following embed code:

[[File:Chicago_Board_Of_Trade_Building.jpg|thumb|Chicago Board Of Trade Building]]

while the localized version

[[Bestand:Chicago_Board_Of_Trade_Building.jpg|thumb|Chicago Board Of Trade Building]]

would make much more sense.
Comment 1 Tisza Gergő 2014-05-01 20:29:41 UTC
The thumb keyword can also be localized, although I'm not sure how to access it in JS (the namespaces are stored in a config variable so that should be easy - this should probably be added to mw.Title).
Comment 2 Tisza Gergő 2014-05-04 05:03:17 UTC
Turns out mw.Title does that already, we just don't use it. Doh.
Comment 3 Gerrit Notification Bot 2014-05-04 05:05:35 UTC
Change 131325 had a related patch set uploaded by Gergő Tisza:
Use localized namespace name in embed wikitext

https://gerrit.wikimedia.org/r/131325
Comment 4 Gerrit Notification Bot 2014-05-05 06:30:08 UTC
Change 131325 merged by jenkins-bot:
Use localized namespace name in embed wikitext

https://gerrit.wikimedia.org/r/131325
Comment 5 Gerrit Notification Bot 2014-05-05 17:58:57 UTC
Change 131509 had a related patch set uploaded by Gergő Tisza:
Revert "Use localized namespace name in embed wikitext"

https://gerrit.wikimedia.org/r/131509
Comment 6 Nemo 2014-05-05 20:44:50 UTC
Per Erik on multimedia list, it's enough to follow content language, as we do for UploadWizard ("File") and the editing toolbar.
Comment 7 Tisza Gergő 2014-05-07 08:04:29 UTC
(In reply to Nemo from comment #6)
> Per Erik on multimedia list, it's enough to follow content language, as we
> do for UploadWizard ("File") and the editing toolbar.

Those are not relevant examples: the editing toolbar is not used cross-wiki, and UploadWizard is (almost) only used on Commons, where the canonical and the contentlang namespace name is the same.
Comment 8 Gerrit Notification Bot 2014-06-16 09:31:10 UTC
Change 131509 merged by jenkins-bot:
Revert "Use localized namespace name in embed wikitext"

https://gerrit.wikimedia.org/r/131509
Comment 9 Nemo 2014-06-16 09:51:06 UTC
(In reply to Gerrit Notification Bot from comment #8)
> Change 131509 merged by jenkins-bot:
> Revert "Use localized namespace name in embed wikitext"

I'm confused. What changed since the multimedia list discussion?
Comment 10 Tisza Gergő 2014-06-17 02:59:53 UTC
Nothing. I had doubts after submitting this patch so I started a mailing list thread about it; there was no consensus (nor much interest, really) so no reason not to merge (except it got forgotten for a while).

I'll leave the bug open for a while longer; if there are many complaints, I'll try the {{ns}} hack.
Comment 11 Nemo 2014-06-17 07:09:04 UTC
When there is no consensus, you should follow standards. That is, wiki content language. Whatever. Here's the link I mentioned above. http://lists.wikimedia.org/pipermail/multimedia/2014-May/000403.html

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links