Last modified: 2014-06-05 18:45:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T66715, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 64715 - VisualEditor: Citation tool should not add empty citation templates
VisualEditor: Citation tool should not add empty citation templates
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Normal minor
: VE-deploy-2014-06-05
Assigned To: Alex Monk
http://en.wikipedia.beta.wmflabs.org/...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-05-01 20:41 UTC by WhatamIdoing
Modified: 2014-06-05 18:45 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
More than one field error (149.14 KB, image/png)
2014-06-05 18:44 UTC, mvolz
Details

Description WhatamIdoing 2014-05-01 20:41:33 UTC
Steps to Reproduce:
1. Citation > Cite web

2. Don't add any information.  Just click "Apply changes".

Result:  <ref>{{Cite web|url = |title = |date = |accessdate = |website = }}</ref>

That's pointless.  If the fields are blank, don't add it (or remove it).


Steps to reproduce, part 2:

1. Citation > Cite web

2. Don't add any information.  Delete all the parameters. 

3. Click "Apply changes".

Result:  <ref>{{Cite web}}</ref>

That's even more pointless.  If there are no parameters, don't add it (or remove it).





Reproducible: Didn't try

(The "invalid" parameter in that diff was manually created by me.  I don't think you can do anything to help the person adding invalid parameters, because there's no way to differentiate between invalid parameter names and valid names that don't happen to be defined in TemplateData.)
Comment 1 Gerrit Notification Bot 2014-05-30 19:37:41 UTC
Change 136436 had a related patch set uploaded by Alex Monk:
Don't allow inserting blank citations

https://gerrit.wikimedia.org/r/136436
Comment 2 Gerrit Notification Bot 2014-06-04 22:57:29 UTC
Change 136436 merged by jenkins-bot:
Don't allow inserting blank citations

https://gerrit.wikimedia.org/r/136436
Comment 3 mvolz 2014-06-05 18:44:56 UTC
Created attachment 15573 [details]
More than one field error
Comment 4 mvolz 2014-06-05 18:45:42 UTC
Whoops, sorry, wrong bug report :(

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links